Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2110683005: Revert of [WeakMemoryCache] Remove Resource from MemoryCache just before destructed (Closed)

Created:
4 years, 5 months ago by hiroshige
Modified:
4 years, 5 months ago
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [WeakMemoryCache] Remove Resource from MemoryCache just before destructed (patchset #3 id:40001 of https://codereview.chromium.org/2066763002/ ) Reason for revert: Reverting field-trial CLs before going to beta, as planned. Original issue's description: > [WeakMemoryCache] Remove Resource from MemoryCache just before destructed > > Previously, if Weak MemoryCache is enabled, Resource could be silently > destructed and MemoryCache's live/dead sizes were not updated. > This may cause larger |m_live/deadSize| and more aggressive pruning. > > This CL calls MemoryCache::remove() just before a Resource is destructed > to make the MemoryCache sizes correct. > > This CL should be reverted before going to beta. > > BUG=603462 > > Committed: https://crrev.com/4706b08cb45742e3b0dcc73ba443522d0cce28da > Cr-Commit-Position: refs/heads/master@{#401536} TBR=japhet@chromium.org,yhirano@chromium.org,oilpan-reviews@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=603462 Committed: https://crrev.com/bb84af54556198947087f4ec33209e5c4ea5bbc3 Cr-Commit-Position: refs/heads/master@{#403087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M third_party/WebKit/Source/core/fetch/MemoryCache.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCache.cpp View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
hiroshige
Created Revert of [WeakMemoryCache] Remove Resource from MemoryCache just before destructed
4 years, 5 months ago (2016-06-30 02:35:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110683005/1
4 years, 5 months ago (2016-06-30 02:35:35 UTC) #3
haraken
LGTM
4 years, 5 months ago (2016-06-30 02:35:45 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/238149)
4 years, 5 months ago (2016-06-30 03:19:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110683005/1
4 years, 5 months ago (2016-06-30 03:31:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 04:29:49 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 04:29:56 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 04:31:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb84af54556198947087f4ec33209e5c4ea5bbc3
Cr-Commit-Position: refs/heads/master@{#403087}

Powered by Google App Engine
This is Rietveld 408576698