Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: cc/proto/property_tree.proto

Issue 2110683004: cc: Move filters to the effect tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/render_surface_impl.cc ('k') | cc/test/animation_timelines_test_common.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/proto/property_tree.proto
diff --git a/cc/proto/property_tree.proto b/cc/proto/property_tree.proto
index 46c9a4ae83fffa22f9e1e0728eb61a8e16371542..890911c99b850e91b62eecfac8edfa241d3cc416 100644
--- a/cc/proto/property_tree.proto
+++ b/cc/proto/property_tree.proto
@@ -86,7 +86,7 @@ message ClipNodeData {
}
// Proto for struct EffectNodeData.
-// NEXT ID: 21
+// NEXT ID: 25
message EffectNodeData {
optional float opacity = 1;
optional float screen_space_opacity = 2;
@@ -96,7 +96,9 @@ message EffectNodeData {
optional bool double_sided = 13;
optional bool is_drawn = 6;
optional bool subtree_hidden = 15;
+ optional bool has_potential_filter_animation = 21;
optional bool has_potential_opacity_animation = 7;
+ optional bool is_currently_animating_filter = 22;
optional bool is_currently_animating_opacity = 16;
optional bool effect_changed = 11;
optional int64 num_copy_requests_in_subtree = 8;
@@ -107,6 +109,9 @@ message EffectNodeData {
optional int64 replica_layer_id = 18;
optional int64 replica_mask_layer_id = 19;
optional Vector2dF surface_contents_scale = 20;
+ // TODO(nyquist): Add support for FilterOperation. See crbug.com/541321.
+ // repeated FilterOperation filters = 23;
+ // repeated FilterOperation background_filters = 24;
}
// Proto for struct ScrollNodeData
« no previous file with comments | « cc/layers/render_surface_impl.cc ('k') | cc/test/animation_timelines_test_common.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698