cc/layers/layer_impl_unittest.cc - Issue 2110683004: cc: Move filters to the effect tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/layer_impl_unittest.cc

Issue 2110683004: cc: Move filters to the effect tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/layers/layer_impl_unittest.cc

diff --git a/cc/layers/layer_impl_unittest.cc b/cc/layers/layer_impl_unittest.cc

index 9868cf8b183bd9b31cfa08676c02d9698f4de187..95c00b8f23e479b828025930a8ed562381b3dd7a 100644

--- a/cc/layers/layer_impl_unittest.cc

+++ b/cc/layers/layer_impl_unittest.cc

@@ -319,7 +319,10 @@ TEST(LayerImplTest, VerifyNeedsUpdateDrawProperties) {

layer->NoteLayerPropertyChanged());

// Unrelated functions, set to the same values, no needs update.

- VERIFY_NO_NEEDS_UPDATE_DRAW_PROPERTIES(layer->SetFilters(arbitrary_filters));

+ layer->test_properties()->filters = arbitrary_filters;

+ host_impl.active_tree()->BuildLayerListAndPropertyTreesForTesting();

+ VERIFY_NO_NEEDS_UPDATE_DRAW_PROPERTIES(

+ layer->OnFilterAnimated(arbitrary_filters));

VERIFY_NO_NEEDS_UPDATE_DRAW_PROPERTIES(layer->SetMasksToBounds(true));

VERIFY_NO_NEEDS_UPDATE_DRAW_PROPERTIES(layer->SetContentsOpaque(true));

VERIFY_NO_NEEDS_UPDATE_DRAW_PROPERTIES(

« no previous file with comments | « cc/layers/layer_impl_test_properties.h ('k') | cc/layers/render_surface_impl.h » ('j') | no next file with comments »