Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: chrome/browser/resources/settings/people_page/sync_page.js

Issue 2110663007: Settings: Fix some BrowserProxy compile issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix type definition Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/sync_page.js
diff --git a/chrome/browser/resources/settings/people_page/sync_page.js b/chrome/browser/resources/settings/people_page/sync_page.js
index f1d0daa814f63163f80f6f2c75795f365e11714c..c5fdc7d67fc27ed7a579ba249d16b52b1935221c 100644
--- a/chrome/browser/resources/settings/people_page/sync_page.js
+++ b/chrome/browser/resources/settings/people_page/sync_page.js
@@ -61,7 +61,7 @@ Polymer({
/**
* The curerntly displayed page.
- * @private {!settings.PageStatus}
+ * @private {?settings.PageStatus}
*/
selectedPage_: {
type: String,
@@ -78,7 +78,7 @@ Polymer({
/**
* The current sync preferences, supplied by SyncBrowserProxy.
- * @type {?settings.SyncPrefs}
+ * @type {settings.SyncPrefs|undefined}
*/
syncPrefs: {
type: Object,
@@ -104,7 +104,7 @@ Polymer({
value: false,
},
- /** @private {!settings.SyncBrowserProxyImpl} */
+ /** @private {!settings.SyncBrowserProxy} */
browserProxy_: {
type: Object,
value: function() {
@@ -241,6 +241,7 @@ Polymer({
* @private
*/
onSingleSyncDataTypeChanged_: function() {
+ assert(this.syncPrefs);
this.browserProxy_.setSyncDatatypes(this.syncPrefs).then(
this.handlePageStatusChanged_.bind(this));
},

Powered by Google App Engine
This is Rietveld 408576698