Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Side by Side Diff: chrome/browser/resources/settings/people_page/sync_browser_proxy.js

Issue 2110663007: Settings: Fix some BrowserProxy compile issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix type definition Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview A helper object used from the the People section to get the 6 * @fileoverview A helper object used from the the People section to get the
7 * status of the sync backend and user preferences on what data to sync. Used 7 * status of the sync backend and user preferences on what data to sync. Used
8 * for both Chrome browser and ChromeOS. 8 * for both Chrome browser and ChromeOS.
9 */ 9 */
10 cr.exportPath('settings'); 10 cr.exportPath('settings');
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 setSyncEncryption: function(syncPrefs) {}, 143 setSyncEncryption: function(syncPrefs) {},
144 144
145 /** 145 /**
146 * Opens the Google Activity Controls url in a new tab. 146 * Opens the Google Activity Controls url in a new tab.
147 */ 147 */
148 openActivityControlsUrl: function() {}, 148 openActivityControlsUrl: function() {},
149 }; 149 };
150 150
151 /** 151 /**
152 * @constructor 152 * @constructor
153 * @implements {SyncBrowserProxy} 153 * @implements {settings.SyncBrowserProxy}
154 */ 154 */
155 function SyncBrowserProxyImpl() {} 155 function SyncBrowserProxyImpl() {}
156 cr.addSingletonGetter(SyncBrowserProxyImpl); 156 cr.addSingletonGetter(SyncBrowserProxyImpl);
157 157
158 SyncBrowserProxyImpl.prototype = { 158 SyncBrowserProxyImpl.prototype = {
159 <if expr="not chromeos"> 159 <if expr="not chromeos">
160 /** @override */ 160 /** @override */
161 startSignIn: function() { 161 startSignIn: function() {
162 // TODO(tommycli): Currently this is always false, but this will become 162 // TODO(tommycli): Currently this is always false, but this will become
163 // a parameter once supervised users are implemented in MD Settings. 163 // a parameter once supervised users are implemented in MD Settings.
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 205
206 /** @override */ 206 /** @override */
207 openActivityControlsUrl: function() { 207 openActivityControlsUrl: function() {
208 chrome.metricsPrivate.recordUserAction( 208 chrome.metricsPrivate.recordUserAction(
209 'Signin_AccountSettings_GoogleActivityControlsClicked'); 209 'Signin_AccountSettings_GoogleActivityControlsClicked');
210 window.open(loadTimeData.getString('activityControlsUrl')); 210 window.open(loadTimeData.getString('activityControlsUrl'));
211 } 211 }
212 }; 212 };
213 213
214 return { 214 return {
215 SyncBrowserProxy: SyncBrowserProxy,
215 SyncBrowserProxyImpl: SyncBrowserProxyImpl, 216 SyncBrowserProxyImpl: SyncBrowserProxyImpl,
216 }; 217 };
217 }); 218 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698