Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: chrome/browser/resources/settings/people_page/change_picture.js

Issue 2110663007: Settings: Fix some BrowserProxy compile issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix type definition Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/change_picture_browser_proxy.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * Contains the possible types of Change Picture selections. 6 * Contains the possible types of Change Picture selections.
7 * @enum {string} 7 * @enum {string}
8 */ 8 */
9 var ChangePictureSelectionTypes = { 9 var ChangePictureSelectionTypes = {
10 CAMERA: 'camera', 10 CAMERA: 'camera',
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 value: '', 104 value: '',
105 }, 105 },
106 106
107 /** @private */ 107 /** @private */
108 selectionTypesEnum_: { 108 selectionTypesEnum_: {
109 type: Object, 109 type: Object,
110 value: ChangePictureSelectionTypes, 110 value: ChangePictureSelectionTypes,
111 readOnly: true, 111 readOnly: true,
112 }, 112 },
113 113
114 /** @private {!settings.ChangePictureBrowserProxyImpl} */ 114 /** @private {!settings.ChangePictureBrowserProxy} */
115 browserProxy_: { 115 browserProxy_: {
116 type: Object, 116 type: Object,
117 value: function() { 117 value: function() {
118 return settings.ChangePictureBrowserProxyImpl.getInstance(); 118 return settings.ChangePictureBrowserProxyImpl.getInstance();
119 }, 119 },
120 }, 120 },
121 }, 121 },
122 122
123 /** @override */ 123 /** @override */
124 attached: function() { 124 attached: function() {
(...skipping 296 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 */ 421 */
422 getAuthorWebsite_: function(selectedItem, defaultImages) { 422 getAuthorWebsite_: function(selectedItem, defaultImages) {
423 if (!this.isAuthorCreditShown_(selectedItem)) 423 if (!this.isAuthorCreditShown_(selectedItem))
424 return ''; 424 return '';
425 425
426 assert(selectedItem.dataset.defaultImageIndex !== null && 426 assert(selectedItem.dataset.defaultImageIndex !== null &&
427 selectedItem.dataset.defaultImageIndex < defaultImages.length); 427 selectedItem.dataset.defaultImageIndex < defaultImages.length);
428 return defaultImages[selectedItem.dataset.defaultImageIndex].website; 428 return defaultImages[selectedItem.dataset.defaultImageIndex].website;
429 }, 429 },
430 }); 430 });
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/change_picture_browser_proxy.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698