Settings: Fix some BrowserProxy compile issues.

chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview A helper object used from the "Site Settings" section to
  * interact with the content settings prefs.
  */
 
 /**
@@ skipping 29 matching lines @@
  */
 var MediaPickerEntry;
 
 cr.define('settings', function() {
   /** @interface */
   function SiteSettingsPrefsBrowserProxy() {}
 
   SiteSettingsPrefsBrowserProxy.prototype = {
     /**
      * Sets the default value for a site settings category.
-     * @param {number} contentType The category to change.
-     * @param {number} defaultValue The value to set as default.
+     * @param {string} contentType The name of the category to change.

[tommycli, 2016/06/30 22:19:45]

I have confirmed (by looking in the C++ handler) that these should all actually
be strings.

[dschuyler, 2016/06/30 22:26:33]

Acknowledged.

+     * @param {string} defaultValue The name of the value to set as default.
      */
     setDefaultValueForContentType: function(contentType, defaultValue) {},
 
     /**
      * Gets the default value for a site settings category.
-     * @param {number} contentType The category to change.
+     * @param {string} contentType The name of the category to query.
      * @return {Promise<boolean>}
      */
     getDefaultValueForContentType: function(contentType) {},
 
     /**
      * Gets the exceptions (site list) for a particular category.
-     * @param {number} contentType The category to change.
+     * @param {string} contentType The name of the category to query.
      * @return {Promise<Array<SiteException>>}
      */
     getExceptionList: function(contentType) {},
 
     /**
      * Resets the category permission for a given origin (expressed as primary
      *    and secondary patterns).
      * @param {string} primaryPattern The origin to change (primary pattern).
      * @param {string} secondaryPattern The embedding origin to change
      *    (secondary pattern).
-     * @param {number} contentType The category to change.
+     * @param {string} contentType The name of the category to reset.
      */
     resetCategoryPermissionForOrigin: function(
         primaryPattern, secondaryPattern, contentType) {},
 
     /**
      * Sets the category permission for a given origin (expressed as primary
      *    and secondary patterns).
      * @param {string} primaryPattern The origin to change (primary pattern).
      * @param {string} secondaryPattern The embedding origin to change
      *    (secondary pattern).
-     * @param {number} contentType The category to change.
+     * @param {string} contentType The name of the category to change.
      * @param {string} value The value to change the permission to.
      */
     setCategoryPermissionForOrigin: function(
         primaryPattern, secondaryPattern, contentType, value) {},
 
     /**
      * Checks whether a pattern is valid.
      * @param {string} pattern The pattern to check
      * @return {!Promise<boolean>} True if the pattern is valid.
      */
     isPatternValid: function(pattern) {},
 
     /**
      * Gets the list of default capture devices for a given type of media. List
      * is returned through a JS call to updateDevicesMenu.
      * @param {string} type The type to look up.
      */
     getDefaultCaptureDevices: function(type) {},
 
     /**
      * Sets a default devices for a given type of media.
      * @param {string} type The type of media to configure.
      * @param {string} defaultValue The id of the media device to set.
      */
     setDefaultCaptureDevice: function(type, defaultValue) {},
   };
 
   /**
    * @constructor
-   * @implements {SiteSettingsPrefsBrowserProxy}
+   * @implements {settings.SiteSettingsPrefsBrowserProxy}
    */
   function SiteSettingsPrefsBrowserProxyImpl() {}
 
   // The singleton instance_ is replaced with a test version of this wrapper
   // during testing.
   cr.addSingletonGetter(SiteSettingsPrefsBrowserProxyImpl);
 
   SiteSettingsPrefsBrowserProxyImpl.prototype = {
     /** @override */
     setDefaultValueForContentType: function(contentType, defaultValue) {
@@ skipping 34 matching lines @@
       chrome.send('getDefaultCaptureDevices', [type]);
     },
 
     /** @override */
     setDefaultCaptureDevice: function(type, defaultValue) {
       chrome.send('setDefaultCaptureDevice', [type, defaultValue]);
     },
   };
 
   return {
+    SiteSettingsPrefsBrowserProxy: SiteSettingsPrefsBrowserProxy,
     SiteSettingsPrefsBrowserProxyImpl: SiteSettingsPrefsBrowserProxyImpl,
   };
 });