| Index: components/update_client/utils_unittest.cc
|
| diff --git a/components/update_client/utils_unittest.cc b/components/update_client/utils_unittest.cc
|
| index 5865419e67aeb16c636f37ce06bd7f6e23ff8c9c..4609b7f656f61b7234347736695e585f859631fb 100644
|
| --- a/components/update_client/utils_unittest.cc
|
| +++ b/components/update_client/utils_unittest.cc
|
| @@ -94,14 +94,14 @@ TEST(UpdateClientUtils, IsValidInstallerAttributeName) {
|
|
|
| const char* const valid_names[] = {"A", "Z", "a", "a-b", "A_B",
|
| "z", "0", "9", "-_"};
|
| - for (const auto& name : valid_names)
|
| + for (const char* name : valid_names)
|
| EXPECT_TRUE(IsValidInstallerAttribute(
|
| make_pair(std::string(name), std::string("value"))));
|
|
|
| const char* const invalid_names[] = {
|
| "", "a=1", " name", "name ", "na me", "<name", "name>",
|
| "\"", "\\", "\xaa", ".", ",", ";", "+"};
|
| - for (const auto& name : invalid_names)
|
| + for (const char* name : invalid_names)
|
| EXPECT_FALSE(IsValidInstallerAttribute(
|
| make_pair(std::string(name), std::string("value"))));
|
| }
|
| @@ -119,13 +119,13 @@ TEST(UpdateClientUtils, IsValidInstallerAttributeValue) {
|
|
|
| const char* const valid_values[] = {"", "a=1", "A", "Z", "a",
|
| "z", "0", "9", "-.,;+_="};
|
| - for (const auto& value : valid_values)
|
| + for (const char* value : valid_values)
|
| EXPECT_TRUE(IsValidInstallerAttribute(
|
| make_pair(std::string("name"), std::string(value))));
|
|
|
| const char* const invalid_values[] = {" ap", "ap ", "a p", "<ap",
|
| "ap>", "\"", "\\", "\xaa"};
|
| - for (const auto& value : invalid_values)
|
| + for (const char* value : invalid_values)
|
| EXPECT_FALSE(IsValidInstallerAttribute(
|
| make_pair(std::string("name"), std::string(value))));
|
| }
|
|
|