Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: components/update_client/update_client.cc

Issue 2110663002: components: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase+one fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/update_client/update_checker.cc ('k') | components/update_client/update_engine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/update_client/update_client.cc
diff --git a/components/update_client/update_client.cc b/components/update_client/update_client.cc
index 176d5b9d5116fb39356d5f01cfc167eaab0e6699..73fce64459c2bb25dd15ff2546fcdfad6851b849 100644
--- a/components/update_client/update_client.cc
+++ b/components/update_client/update_client.cc
@@ -196,7 +196,7 @@ bool UpdateClientImpl::GetCrxUpdateState(const std::string& id,
bool UpdateClientImpl::IsUpdating(const std::string& id) const {
DCHECK(thread_checker_.CalledOnValidThread());
- for (const auto& task : tasks_) {
+ for (const auto* task : tasks_) {
const auto ids(task->GetIds());
if (std::find(ids.begin(), ids.end(), id) != ids.end()) {
return true;
@@ -225,7 +225,7 @@ void UpdateClientImpl::Stop() {
// they have not picked up by the update engine, and not shared with any
// task runner yet.
while (!task_queue_.empty()) {
- const auto task(task_queue_.front());
+ auto* task(task_queue_.front());
task_queue_.pop();
task->Cancel();
}
« no previous file with comments | « components/update_client/update_checker.cc ('k') | components/update_client/update_engine.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698