components/proximity_auth/ble/bluetooth_low_energy_characteristics_finder.cc - Issue 2110663002: components: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/proximity_auth/ble/bluetooth_low_energy_characteristics_finder.cc

Issue 2110663002: components: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase+one fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/precache/core/precache_session_table_unittest.cc ('k') | components/proximity_auth/ble/bluetooth_low_energy_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/proximity_auth/ble/bluetooth_low_energy_characteristics_finder.cc

diff --git a/components/proximity_auth/ble/bluetooth_low_energy_characteristics_finder.cc b/components/proximity_auth/ble/bluetooth_low_energy_characteristics_finder.cc

index abb7414205a668d9b3c4c52fd78775c0d193a0e2..fdfd2862b6b9a99b62e3dfd6635dd95ba27fc03a 100644

--- a/components/proximity_auth/ble/bluetooth_low_energy_characteristics_finder.cc

+++ b/components/proximity_auth/ble/bluetooth_low_energy_characteristics_finder.cc

@@ -91,14 +91,14 @@ void BluetoothLowEnergyCharacteristicsFinder::ScanRemoteCharacteristics(

device->GetGattServices();

PA_LOG(INFO) << device->GetAddress() << " has " << services.size()

<< " services.";

- for (const auto& service : services) {

+ for (const auto* service : services) {

if (service->GetUUID() == service_uuid) {

// Right service found, now scaning its characteristics.

std::vector<device::BluetoothRemoteGattCharacteristic*>

characteristics = service->GetCharacteristics();

PA_LOG(INFO) << "Service " << service_uuid.canonical_value() << " has "

<< characteristics.size() << " characteristics.";

- for (const auto& characteristic : characteristics) {

+ for (auto* characteristic : characteristics) {

HandleCharacteristicUpdate(characteristic);

}

break;