components/password_manager/core/browser/password_manager_util.cc - Issue 2110663002: components: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_util.cc

Issue 2110663002: components: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase+one fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/login_database_unittest.cc ('k') | components/password_manager/core/browser/password_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_util.cc

diff --git a/components/password_manager/core/browser/password_manager_util.cc b/components/password_manager/core/browser/password_manager_util.cc

index e8804193affa8cada299ff407b9b7ba30a2294f4..dc0e7e22d47bc9e283ba76efd25f29b94d93e122 100644

--- a/components/password_manager/core/browser/password_manager_util.cc

+++ b/components/password_manager/core/browser/password_manager_util.cc

@@ -63,7 +63,7 @@ void FindDuplicates(

void TrimUsernameOnlyCredentials(

ScopedVector<autofill::PasswordForm>* android_credentials) {

ScopedVector<autofill::PasswordForm> result;

- for (auto& form : *android_credentials) {

+ for (auto*& form : *android_credentials) {

if (form->scheme == autofill::PasswordForm::SCHEME_USERNAME_ONLY) {

if (form->federation_origin.unique())

continue;