components/keyed_service/core/dependency_manager.cc - Issue 2110663002: components: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/keyed_service/core/dependency_manager.cc

Issue 2110663002: components: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase+one fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/guest_view/browser/guest_view_message_filter.cc ('k') | components/memory_coordinator/browser/memory_coordinator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/keyed_service/core/dependency_manager.cc

diff --git a/components/keyed_service/core/dependency_manager.cc b/components/keyed_service/core/dependency_manager.cc

index 4f35244e04fa3332c13ce0b81ec107173e488813..3cc264beddd64d036864bab7e8a9a46795dafacb 100644

--- a/components/keyed_service/core/dependency_manager.cc

+++ b/components/keyed_service/core/dependency_manager.cc

@@ -41,7 +41,7 @@ void DependencyManager::RegisterPrefsForServices(

NOTREACHED();

}

- for (const auto& dependency_node : construction_order) {

+ for (auto* dependency_node : construction_order) {

KeyedServiceBaseFactory* factory =

static_cast<KeyedServiceBaseFactory*>(dependency_node);

factory->RegisterPrefsIfNecessaryForContext(context, pref_registry);

@@ -63,7 +63,7 @@ void DependencyManager::CreateContextServices(base::SupportsUserData* context,

DumpContextDependencies(context);

#endif

- for (const auto& dependency_node : construction_order) {

+ for (auto* dependency_node : construction_order) {

KeyedServiceBaseFactory* factory =

static_cast<KeyedServiceBaseFactory*>(dependency_node);

if (is_testing_context && factory->ServiceIsNULLWhileTesting() &&

@@ -86,7 +86,7 @@ void DependencyManager::DestroyContextServices(

DumpContextDependencies(context);

#endif

- for (const auto& dependency_node : destruction_order) {

+ for (auto* dependency_node : destruction_order) {

KeyedServiceBaseFactory* factory =

static_cast<KeyedServiceBaseFactory*>(dependency_node);

factory->ContextShutdown(context);

@@ -97,7 +97,7 @@ void DependencyManager::DestroyContextServices(

dead_context_pointers_.insert(context);

#endif

- for (const auto& dependency_node : destruction_order) {

+ for (auto* dependency_node : destruction_order) {

KeyedServiceBaseFactory* factory =

static_cast<KeyedServiceBaseFactory*>(dependency_node);

factory->ContextDestroyed(context);