Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: components/guest_view/browser/guest_view_manager.cc

Issue 2110663002: components: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase+one fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/guest_view/browser/guest_view_manager.cc
diff --git a/components/guest_view/browser/guest_view_manager.cc b/components/guest_view/browser/guest_view_manager.cc
index 7f0d6841b9a86684f4a3ef80ab355b6fdeace515..d98ef1ac37b83393644195e7fb69d9211c1d3718 100644
--- a/components/guest_view/browser/guest_view_manager.cc
+++ b/components/guest_view/browser/guest_view_manager.cc
@@ -113,7 +113,8 @@ void GuestViewManager::AttachGuest(int embedder_process_id,
int element_instance_id,
int guest_instance_id,
const base::DictionaryValue& attach_params) {
- auto guest_view = GuestViewBase::From(embedder_process_id, guest_instance_id);
+ auto* guest_view =
+ GuestViewBase::From(embedder_process_id, guest_instance_id);
if (!guest_view)
return;
@@ -126,8 +127,8 @@ void GuestViewManager::AttachGuest(int embedder_process_id,
if (old_guest_instance_id == guest_instance_id)
return;
- auto old_guest_view = GuestViewBase::From(embedder_process_id,
- old_guest_instance_id);
+ auto* old_guest_view =
+ GuestViewBase::From(embedder_process_id, old_guest_instance_id);
old_guest_view->Destroy();
}
instance_id_map_[key] = guest_instance_id;
@@ -176,12 +177,12 @@ content::WebContents* GuestViewManager::CreateGuestWithWebContentsParams(
const std::string& view_type,
content::WebContents* owner_web_contents,
const content::WebContents::CreateParams& create_params) {
- auto guest = CreateGuestInternal(owner_web_contents, view_type);
+ auto* guest = CreateGuestInternal(owner_web_contents, view_type);
if (!guest)
return nullptr;
content::WebContents::CreateParams guest_create_params(create_params);
guest_create_params.guest_delegate = guest;
- auto guest_web_contents = WebContents::Create(guest_create_params);
+ auto* guest_web_contents = WebContents::Create(guest_create_params);
guest->InitWithWebContents(base::DictionaryValue(), guest_web_contents);
return guest_web_contents;
}
@@ -218,7 +219,7 @@ SiteInstance* GuestViewManager::GetGuestSiteInstance(
bool GuestViewManager::ForEachGuest(WebContents* owner_web_contents,
const GuestCallback& callback) {
for (const auto& guest : guest_web_contents_by_instance_id_) {
- auto guest_view = GuestViewBase::FromWebContents(guest.second);
+ auto* guest_view = GuestViewBase::FromWebContents(guest.second);
if (guest_view->owner_web_contents() != owner_web_contents)
continue;
@@ -428,7 +429,7 @@ bool GuestViewManager::CanUseGuestInstanceID(int guest_instance_id) {
bool GuestViewManager::GetFullPageGuestHelper(
content::WebContents** result,
content::WebContents* guest_web_contents) {
- auto guest_view = GuestViewBase::FromWebContents(guest_web_contents);
+ auto* guest_view = GuestViewBase::FromWebContents(guest_web_contents);
if (guest_view && guest_view->is_full_page_plugin()) {
*result = guest_web_contents;
return true;
@@ -457,7 +458,7 @@ bool GuestViewManager::CanEmbedderAccessInstanceID(
if (it == guest_web_contents_by_instance_id_.end())
return true;
- auto guest_view = GuestViewBase::FromWebContents(it->second);
+ auto* guest_view = GuestViewBase::FromWebContents(it->second);
if (!guest_view)
return false;
« no previous file with comments | « components/guest_view/browser/guest_view_base.cc ('k') | components/guest_view/browser/guest_view_message_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698