components/password_manager/core/browser/login_database_unittest.cc - Issue 2110663002: components: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/login_database_unittest.cc

Issue 2110663002: components: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/credential_manager_pending_request_task.cc ('K') | « components/password_manager/core/browser/credential_manager_pending_request_task.cc ('k') | components/password_manager/core/browser/password_manager.cc » ('j') | components/password_manager/core/browser/password_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/login_database_unittest.cc

diff --git a/components/password_manager/core/browser/login_database_unittest.cc b/components/password_manager/core/browser/login_database_unittest.cc

index b9c79834ca7bf63009666b6e59d3200afec27b99..a682e0d973d965d1433102dc024610e1fd029c0e 100644

--- a/components/password_manager/core/browser/login_database_unittest.cc

+++ b/components/password_manager/core/browser/login_database_unittest.cc

@@ -844,7 +844,7 @@ TEST_F(LoginDatabaseTest, GetAutoSignInLogins) {

EXPECT_TRUE(db().GetAutoSignInLogins(&result));

EXPECT_EQ(4U, result.size());

- for (const auto& form : result)

+ for (auto* form : result)

vabr (Chromium) 2016/07/19 07:54:09 optional: "const auto*" Also below on line 868.

vmpstr 2016/07/19 19:49:31 Done.

EXPECT_FALSE(form->skip_zero_click);

EXPECT_TRUE(db().DisableAutoSignInForOrigin(origin));

@@ -865,7 +865,7 @@ TEST_F(LoginDatabaseTest, DisableAutoSignInForOrigin) {

EXPECT_TRUE(AddZeroClickableLogin(&db(), "foo4", origin4));

EXPECT_TRUE(db().GetAutofillableLogins(&result));

- for (const auto& form : result)

+ for (auto* form : result)

EXPECT_FALSE(form->skip_zero_click);

EXPECT_TRUE(db().DisableAutoSignInForOrigin(origin1));