components/update_client/update_client.cc - Issue 2110663002: components: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/update_client/update_client.cc

Issue 2110663002: components: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_store.cc ('K') | « components/update_client/update_checker.cc ('k') | components/update_client/update_engine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/update_client/update_client.cc

diff --git a/components/update_client/update_client.cc b/components/update_client/update_client.cc

index 176d5b9d5116fb39356d5f01cfc167eaab0e6699..ce9e1b011ebd073decbf752b9f82bb879b245688 100644

--- a/components/update_client/update_client.cc

+++ b/components/update_client/update_client.cc

@@ -196,7 +196,7 @@ bool UpdateClientImpl::GetCrxUpdateState(const std::string& id,

bool UpdateClientImpl::IsUpdating(const std::string& id) const {

DCHECK(thread_checker_.CalledOnValidThread());

- for (const auto& task : tasks_) {

+ for (auto* task : tasks_) {

const auto ids(task->GetIds());

if (std::find(ids.begin(), ids.end(), id) != ids.end()) {

return true;

@@ -225,7 +225,7 @@ void UpdateClientImpl::Stop() {

// they have not picked up by the update engine, and not shared with any

// task runner yet.

while (!task_queue_.empty()) {

- const auto task(task_queue_.front());

+ auto* task(task_queue_.front());

task_queue_.pop();

task->Cancel();

}