components/safe_browsing_db/remote_database_manager.cc - Issue 2110663002: components: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/remote_database_manager.cc

Issue 2110663002: components: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_store.cc ('K') | « components/safe_browsing_db/database_manager.cc ('k') | components/scheduler/base/task_queue_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/remote_database_manager.cc

diff --git a/components/safe_browsing_db/remote_database_manager.cc b/components/safe_browsing_db/remote_database_manager.cc

index 472cffc8d09abeea78809f6f12195b948e13a92f..4f3a7f1785763303c323032ae4ce7fc9e140df62 100644

--- a/components/safe_browsing_db/remote_database_manager.cc

+++ b/components/safe_browsing_db/remote_database_manager.cc

@@ -291,7 +291,7 @@ void RemoteSafeBrowsingDatabaseManager::StopOnIOThread(bool shutdown) {

// Call back and delete any remaining clients. OnRequestDone() modifies

// |current_requests_|, so we make a copy first.

std::vector<ClientRequest*> to_callback(current_requests_);

- for (auto req : to_callback) {

+ for (auto* req : to_callback) {

DVLOG(1) << "Stopping: Invoking unfinished req for URL " << req->url();

req->OnRequestDone(SB_THREAT_TYPE_SAFE, ThreatMetadata());

}