Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Side by Side Diff: components/devtools_discovery/devtools_discovery_manager.cc

Issue 2110663002: components: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase+one fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/cronet/ios/Cronet.mm ('k') | components/domain_reliability/config.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/devtools_discovery/devtools_discovery_manager.h" 5 #include "components/devtools_discovery/devtools_discovery_manager.h"
6 6
7 #include "base/stl_util.h" 7 #include "base/stl_util.h"
8 #include "components/devtools_discovery/basic_target_descriptor.h" 8 #include "components/devtools_discovery/basic_target_descriptor.h"
9 #include "content/public/browser/devtools_agent_host.h" 9 #include "content/public/browser/devtools_agent_host.h"
10 10
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 std::unique_ptr<DevToolsTargetDescriptor> DevToolsDiscoveryManager::CreateNew( 48 std::unique_ptr<DevToolsTargetDescriptor> DevToolsDiscoveryManager::CreateNew(
49 const GURL& url) { 49 const GURL& url) {
50 if (create_callback_.is_null()) 50 if (create_callback_.is_null())
51 return nullptr; 51 return nullptr;
52 return create_callback_.Run(url); 52 return create_callback_.Run(url);
53 } 53 }
54 54
55 DevToolsTargetDescriptor::List 55 DevToolsTargetDescriptor::List
56 DevToolsDiscoveryManager::GetDescriptorsFromProviders() { 56 DevToolsDiscoveryManager::GetDescriptorsFromProviders() {
57 DevToolsTargetDescriptor::List result; 57 DevToolsTargetDescriptor::List result;
58 for (const auto& provider : providers_) { 58 for (auto* provider : providers_) {
59 DevToolsTargetDescriptor::List partial = provider->GetDescriptors(); 59 DevToolsTargetDescriptor::List partial = provider->GetDescriptors();
60 result.insert(result.begin(), partial.begin(), partial.end()); 60 result.insert(result.begin(), partial.begin(), partial.end());
61 } 61 }
62 return result; 62 return result;
63 } 63 }
64 64
65 std::unique_ptr<base::DictionaryValue> 65 std::unique_ptr<base::DictionaryValue>
66 DevToolsDiscoveryManager::HandleNewTargetCommand( 66 DevToolsDiscoveryManager::HandleNewTargetCommand(
67 base::DictionaryValue* command_dict) { 67 base::DictionaryValue* command_dict) {
68 int id; 68 int id;
(...skipping 14 matching lines...) Expand all
83 std::unique_ptr<base::DictionaryValue> cmd_result( 83 std::unique_ptr<base::DictionaryValue> cmd_result(
84 new base::DictionaryValue()); 84 new base::DictionaryValue());
85 cmd_result->SetString("pageId", descriptor->GetId()); 85 cmd_result->SetString("pageId", descriptor->GetId());
86 result->Set("result", std::move(cmd_result)); 86 result->Set("result", std::move(cmd_result));
87 return result; 87 return result;
88 } 88 }
89 return nullptr; 89 return nullptr;
90 } 90 }
91 91
92 } // namespace devtools_discovery 92 } // namespace devtools_discovery
OLDNEW
« no previous file with comments | « components/cronet/ios/Cronet.mm ('k') | components/domain_reliability/config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698