Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: components/certificate_transparency/log_dns_client.cc

Issue 2110663002: components: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase+one fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/certificate_transparency/log_dns_client.h" 5 #include "components/certificate_transparency/log_dns_client.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 21 matching lines...) Expand all
32 DCHECK(txt); 32 DCHECK(txt);
33 33
34 net::DnsRecordParser parser = response.Parser(); 34 net::DnsRecordParser parser = response.Parser();
35 // We don't care about the creation time, since we're going to throw 35 // We don't care about the creation time, since we're going to throw
36 // |parsed_record| away as soon as we've extracted the payload, so provide 36 // |parsed_record| away as soon as we've extracted the payload, so provide
37 // the "null" time. 37 // the "null" time.
38 auto parsed_record = net::RecordParsed::CreateFrom(&parser, base::Time()); 38 auto parsed_record = net::RecordParsed::CreateFrom(&parser, base::Time());
39 if (parsed_record == nullptr) 39 if (parsed_record == nullptr)
40 return false; 40 return false;
41 41
42 auto txt_record = parsed_record->rdata<net::TxtRecordRdata>(); 42 auto* txt_record = parsed_record->rdata<net::TxtRecordRdata>();
43 if (txt_record == nullptr) 43 if (txt_record == nullptr)
44 return false; 44 return false;
45 45
46 *txt = base::JoinString(txt_record->texts(), ""); 46 *txt = base::JoinString(txt_record->texts(), "");
47 return true; 47 return true;
48 } 48 }
49 49
50 bool ParseLeafIndex(const net::DnsResponse& response, uint64_t* index) { 50 bool ParseLeafIndex(const net::DnsResponse& response, uint64_t* index) {
51 DCHECK(index); 51 DCHECK(index);
52 52
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 audit_path_nodes_received, query.callback); 285 audit_path_nodes_received, query.callback);
286 return; 286 return;
287 } 287 }
288 288
289 base::ThreadTaskRunnerHandle::Get()->PostTask( 289 base::ThreadTaskRunnerHandle::Get()->PostTask(
290 FROM_HERE, 290 FROM_HERE,
291 base::Bind(query.callback, net::OK, base::Passed(std::move(proof)))); 291 base::Bind(query.callback, net::OK, base::Passed(std::move(proof))));
292 } 292 }
293 293
294 } // namespace certificate_transparency 294 } // namespace certificate_transparency
OLDNEW
« no previous file with comments | « components/bubble/bubble_manager.cc ('k') | components/component_updater/component_updater_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698