Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: components/arc/storage_manager/arc_storage_manager.cc

Issue 2110663002: components: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase+one fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/arc/storage_manager/arc_storage_manager.h" 5 #include "components/arc/storage_manager/arc_storage_manager.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 22 matching lines...) Expand all
33 g_arc_storage_manager = nullptr; 33 g_arc_storage_manager = nullptr;
34 } 34 }
35 35
36 // static 36 // static
37 ArcStorageManager* ArcStorageManager::Get() { 37 ArcStorageManager* ArcStorageManager::Get() {
38 DCHECK(g_arc_storage_manager); 38 DCHECK(g_arc_storage_manager);
39 return g_arc_storage_manager; 39 return g_arc_storage_manager;
40 } 40 }
41 41
42 bool ArcStorageManager::OpenPrivateVolumeSettings() { 42 bool ArcStorageManager::OpenPrivateVolumeSettings() {
43 auto storage_manager_instance = GetStorageManagerInstance(); 43 auto* storage_manager_instance = GetStorageManagerInstance();
44 if (!storage_manager_instance) { 44 if (!storage_manager_instance) {
45 return false; 45 return false;
46 } 46 }
47 storage_manager_instance->OpenPrivateVolumeSettings(); 47 storage_manager_instance->OpenPrivateVolumeSettings();
48 return true; 48 return true;
49 } 49 }
50 50
51 bool ArcStorageManager::GetApplicationsSize( 51 bool ArcStorageManager::GetApplicationsSize(
52 const GetApplicationsSizeCallback& callback) { 52 const GetApplicationsSizeCallback& callback) {
53 auto storage_manager_instance = GetStorageManagerInstance(); 53 auto* storage_manager_instance = GetStorageManagerInstance();
54 if (!storage_manager_instance) { 54 if (!storage_manager_instance) {
55 return false; 55 return false;
56 } 56 }
57 storage_manager_instance->GetApplicationsSize(callback); 57 storage_manager_instance->GetApplicationsSize(callback);
58 return true; 58 return true;
59 } 59 }
60 60
61 bool ArcStorageManager::DeleteApplicationsCache( 61 bool ArcStorageManager::DeleteApplicationsCache(
62 const base::Callback<void()>& callback) { 62 const base::Callback<void()>& callback) {
63 auto storage_manager_instance = GetStorageManagerInstance(); 63 auto* storage_manager_instance = GetStorageManagerInstance();
64 if (!storage_manager_instance) { 64 if (!storage_manager_instance) {
65 return false; 65 return false;
66 } 66 }
67 storage_manager_instance->DeleteApplicationsCache(callback); 67 storage_manager_instance->DeleteApplicationsCache(callback);
68 return true; 68 return true;
69 } 69 }
70 70
71 mojom::StorageManagerInstance* ArcStorageManager::GetStorageManagerInstance() { 71 mojom::StorageManagerInstance* ArcStorageManager::GetStorageManagerInstance() {
72 auto bridge_service = arc_bridge_service(); 72 auto* bridge_service = arc_bridge_service();
73 auto storage_manager_instance = bridge_service->storage_manager()->instance(); 73 auto* storage_manager_instance =
74 bridge_service->storage_manager()->instance();
74 if (!storage_manager_instance) { 75 if (!storage_manager_instance) {
75 DLOG(WARNING) << "ARC storage manager instance is not ready."; 76 DLOG(WARNING) << "ARC storage manager instance is not ready.";
76 return nullptr; 77 return nullptr;
77 } 78 }
78 auto storage_manager_version = bridge_service->storage_manager()->version(); 79 auto storage_manager_version = bridge_service->storage_manager()->version();
79 if (storage_manager_version < kMinInstanceVersion) { 80 if (storage_manager_version < kMinInstanceVersion) {
80 DLOG(ERROR) << "ARC storage manager instance (version " 81 DLOG(ERROR) << "ARC storage manager instance (version "
81 << storage_manager_version << ") is too old."; 82 << storage_manager_version << ") is too old.";
82 return nullptr; 83 return nullptr;
83 } 84 }
84 return storage_manager_instance; 85 return storage_manager_instance;
85 } 86 }
86 87
87 } // namespace arc 88 } // namespace arc
OLDNEW
« no previous file with comments | « components/arc/bluetooth/arc_bluetooth_bridge.cc ('k') | components/autofill/content/renderer/form_autofill_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698