components: Change auto to not deduce raw pointers.

components/update_client/utils_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_path.h"
 #include "base/path_service.h"
 #include "components/update_client/utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
@@ skipping 76 matching lines @@
       make_pair(std::string(0, 'a'), std::string("value"))));
   EXPECT_TRUE(IsValidInstallerAttribute(
       make_pair(std::string(1, 'a'), std::string("value"))));
   EXPECT_TRUE(IsValidInstallerAttribute(
       make_pair(std::string(256, 'a'), std::string("value"))));
   EXPECT_FALSE(IsValidInstallerAttribute(
       make_pair(std::string(257, 'a'), std::string("value"))));
 
   const char* const valid_names[] = {"A", "Z", "a", "a-b", "A_B",
                                      "z", "0", "9", "-_"};
-  for (const auto& name : valid_names)
+  for (auto* name : valid_names)
     EXPECT_TRUE(IsValidInstallerAttribute(
         make_pair(std::string(name), std::string("value"))));
 
   const char* const invalid_names[] = {
       "",   "a=1", " name", "name ", "na me", "<name", "name>",
       "\"", "\\",  "\xaa",  ".",     ",",     ";",     "+"};
-  for (const auto& name : invalid_names)
+  for (auto* name : invalid_names)
     EXPECT_FALSE(IsValidInstallerAttribute(
         make_pair(std::string(name), std::string("value"))));
 }
 
 // Tests that the value of an InstallerAttribute matches
 // ^[-.,;+_=a-zA-Z0-9]{0,256}$
 TEST(UpdateClientUtils, IsValidInstallerAttributeValue) {
   // Test the length boundaries.
   EXPECT_TRUE(IsValidInstallerAttribute(
       make_pair(std::string("name"), std::string(0, 'a'))));
   EXPECT_TRUE(IsValidInstallerAttribute(
       make_pair(std::string("name"), std::string(256, 'a'))));
   EXPECT_FALSE(IsValidInstallerAttribute(
       make_pair(std::string("name"), std::string(257, 'a'))));
 
   const char* const valid_values[] = {"",  "a=1", "A", "Z",      "a",
                                       "z", "0",   "9", "-.,;+_="};
-  for (const auto& value : valid_values)
+  for (auto* value : valid_values)
     EXPECT_TRUE(IsValidInstallerAttribute(
         make_pair(std::string("name"), std::string(value))));
 
   const char* const invalid_values[] = {" ap", "ap ", "a p", "<ap",
                                         "ap>", "\"",  "\\",  "\xaa"};
-  for (const auto& value : invalid_values)
+  for (auto* value : invalid_values)
     EXPECT_FALSE(IsValidInstallerAttribute(
         make_pair(std::string("name"), std::string(value))));
 }
 
 TEST(UpdateClientUtils, RemoveUnsecureUrls) {
   const GURL test1[] = {GURL("http://foo"), GURL("https://foo")};
   std::vector<GURL> urls(std::begin(test1), std::end(test1));
   RemoveUnsecureUrls(&urls);
   EXPECT_EQ(1u, urls.size());
   EXPECT_EQ(urls[0], GURL("https://foo"));
@@ skipping 16 matching lines @@
   RemoveUnsecureUrls(&urls);
   EXPECT_EQ(0u, urls.size());
 
   const GURL test5[] = {GURL("http://foo"), GURL("http://bar")};
   urls.assign(std::begin(test5), std::end(test5));
   RemoveUnsecureUrls(&urls);
   EXPECT_EQ(0u, urls.size());
 }
 
 }  // namespace update_client