components: Change auto to not deduce raw pointers.

components/autofill/content/renderer/form_autofill_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/form_autofill_util.h"
 
 #include <map>
 #include <set>
 
 #include "base/command_line.h"
@@ skipping 657 matching lines @@
       continue;
 
     tag_names.push_back(parent_node.to<WebElement>().tagName().utf8());
   }
   return tag_names;
 }
 
 bool IsLabelValid(base::StringPiece16 inferred_label,
     const std::vector<base::char16>& stop_words) {
   // If |inferred_label| has any character other than those in |stop_words|.
-  auto first_non_stop_word = std::find_if(inferred_label.begin(),
-      inferred_label.end(), [&stop_words](base::char16 c) {
-          return !ContainsValue(stop_words, c);
-      });
+  auto* first_non_stop_word = std::find_if(
+      inferred_label.begin(), inferred_label.end(),
+      [&stop_words](base::char16 c) { return !ContainsValue(stop_words, c); });
   return first_non_stop_word != inferred_label.end();
 }
 
 // Infers corresponding label for |element| from surrounding context in the DOM,
 // e.g. the contents of the preceding <p> tag or text element.
 base::string16 InferLabelForElement(const WebFormControlElement& element,
     const std::vector<base::char16>& stop_words) {
   base::string16 inferred_label;
 
   if (IsCheckableElement(toWebInputElement(&element))) {
@@ skipping 447 matching lines @@
     }
     TruncateString(&form_fields[field_idx]->label, kMaxDataLength);
 
     if (field && *form_control_element == control_element)
       *field = *form_fields[field_idx];
 
     ++field_idx;
   }
 
   // Copy the created FormFields into the resulting FormData object.
-  for (const auto& iter : form_fields)
+  for (auto* iter : form_fields)

[vabr (Chromium), 2016/07/19 07:54:08]

optional: This could even be "const auto*".

[vmpstr, 2016/07/19 19:49:30]

Done.

     form->fields.push_back(*iter);
   return true;
 }
 
 bool UnownedFormElementsAndFieldSetsToFormData(
     const std::vector<blink::WebElement>& fieldsets,
     const std::vector<blink::WebFormControlElement>& control_elements,
     const blink::WebFormControlElement* element,
     const blink::WebDocument& document,
     ExtractMask extract_mask,
@@ skipping 384 matching lines @@
 
   const char* const kKeywords[] = {
     "payment",
     "checkout",
     "address",
     "delivery",
     "shipping",
     "wallet"
   };
 
-  for (const auto& keyword : kKeywords) {
+  for (auto* keyword : kKeywords) {

[vabr (Chromium), 2016/07/19 07:54:08]

nit: "const auto*" to emphasise that |keyword| points in fact to a const object?

[vmpstr, 2016/07/19 19:49:30]

Done.

     // Compare char16 elements of |title| with char elements of |keyword| using
     // operator==.
     auto title_pos = std::search(title.begin(), title.end(),
                                  keyword, keyword + strlen(keyword));
     if (title_pos != title.end() ||
         path.find(keyword) != std::string::npos) {
       form->is_formless_checkout = true;
       // Found a keyword: treat this as an unowned form.
       return UnownedFormElementsAndFieldSetsToFormData(
           fieldsets, control_elements, element, document, extract_mask, form,
@@ skipping 224 matching lines @@
     // Zero selection start is for password manager, which can show usernames
     // that do not begin with the user input value.
     selection_start = (offset == base::string16::npos) ? 0 : offset;
   }
 
   input_element->setSelectionRange(selection_start, suggestion.length());
 }
 
 }  // namespace form_util
 }  // namespace autofill