Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2954)

Unified Diff: chrome/browser/resources/settings/printing_page/printing_page.js

Issue 2110653003: CUPS: MD Settings printers subpage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address stevenjb@'s comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/printing_page/printing_page.js
diff --git a/chrome/browser/resources/settings/printing_page/printing_page.js b/chrome/browser/resources/settings/printing_page/printing_page.js
index 43df17710df47a5676f54a1713daaad6fc8d5c78..a4300e5886d81a7286f3d13ce15135a2ab1d7d3d 100644
--- a/chrome/browser/resources/settings/printing_page/printing_page.js
+++ b/chrome/browser/resources/settings/printing_page/printing_page.js
@@ -6,14 +6,27 @@ Polymer({
is: 'settings-printing-page',
properties: {
+ /** Preferences state. */
prefs: {
type: Object,
notify: true,
},
+
+ /** The current active route. */
+ currentRoute: {
+ type: Object,
+ notify: true,
+ },
},
/** @private */
michaelpg 2016/07/13 21:14:49 this should be directly above each function below:
xdai1 2016/07/14 17:48:33 Done.
- onManageTap_: function() {
- window.open(loadTimeData.getString('devicesUrl'));
+<if expr="chromeos">
+ onTapCupsPrinters_: function() {
michaelpg 2016/07/13 21:14:49 @private above this line
xdai1 2016/07/14 17:48:33 Done.
+ this.$.pages.setSubpageChain(['cups-printers']);
+ },
+</if>
+
+ onTapCloudPrinters_: function() {
michaelpg 2016/07/13 21:14:49 @private above this line
xdai1 2016/07/14 17:48:33 Done.
+ this.$.pages.setSubpageChain(['cloud-printers']);
},
});

Powered by Google App Engine
This is Rietveld 408576698