Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2110643002: ash: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
Reviewers:
danakj, sky, dcheng
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=sky, danakj, dcheng BUG=554600 Committed: https://crrev.com/eb900a1e034e1abddcaf7fdd7bb05c0d75cf0b62 Cr-Commit-Position: refs/heads/master@{#402668}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/overview/scoped_transform_overview_window.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M ash/common/wm/overview/window_grid.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/common/wm/workspace/workspace_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/host/ash_window_tree_host_unified.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/mus/layout_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/mus/user_window_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/toast/toast_overlay.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
vmpstr
Please take a look.
4 years, 5 months ago (2016-06-28 21:36:36 UTC) #1
danakj
LGTM
4 years, 5 months ago (2016-06-28 22:09:08 UTC) #2
sky
LGTM
4 years, 5 months ago (2016-06-28 22:19:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110643002/1
4 years, 5 months ago (2016-06-28 22:26:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 02:22:42 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 02:26:06 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/eb900a1e034e1abddcaf7fdd7bb05c0d75cf0b62
Cr-Commit-Position: refs/heads/master@{#402668}

Powered by Google App Engine
This is Rietveld 408576698