Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 2110603002: Remove calls to MessageLoop::current() in chrome. (Closed)

Created:
4 years, 5 months ago by fdoray
Modified:
4 years, 5 months ago
CC:
achuith+watch_chromium.org, asvitkine+watch_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, dzhioev+watch_chromium.org, extensions-reviews_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to MessageLoop::current() in chrome. Why? The fact that there's a MessageLoop on the thread is an unnecessary implementation detail. When browser threads are migrated to base/task_scheduler, tasks will no longer have access to a MessageLoop. These changes were generated manually. BUG=616447 Committed: https://crrev.com/c16c6f870e4c1546b1e5e93205caa59d5c33e513 Cr-Commit-Position: refs/heads/master@{#402816}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -42 lines) Patch
M chrome/browser/android/net/external_estimate_provider_android.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_error_reporter.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_error_reporter.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.h View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/metrics/thread_watcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/process_singleton_posix.cc View 10 chunks +13 lines, -13 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/image_writer/disk_unmounter_mac.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
fdoray
Can you review this CL? Thanks.
4 years, 5 months ago (2016-06-28 20:26:24 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-06-29 15:17:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110603002/1
4 years, 5 months ago (2016-06-29 15:19:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 15:27:52 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 15:28:02 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 15:29:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c16c6f870e4c1546b1e5e93205caa59d5c33e513
Cr-Commit-Position: refs/heads/master@{#402816}

Powered by Google App Engine
This is Rietveld 408576698