components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc - Issue 2110563002: Use AutofillProfileComparator in place of ad-hoc merge logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc

Issue 2110563002: Use AutofillProfileComparator in place of ad-hoc merge logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@merge

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc ('k') | components/browser_sync/browser/profile_sync_service_autofill_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc

diff --git a/components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc b/components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc

index da62a11312cf4ff9b2301e2d43e5cccd2741ab17..cc4d442e612985b47d4b93c658719a13e797c960 100644

--- a/components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc

+++ b/components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc

@@ -402,6 +402,7 @@ TEST_F(AutofillProfileSyncableServiceTest, MergeSimilarProfiles) {

// should never overwrite a verified one.

AutofillProfile expected_profile(profile1);

expected_profile.set_origin(origin_present1);

+ expected_profile.SetRawInfo(NAME_FULL, ASCIIToUTF16("John"));

// Merging two profile adds their user count.

expected_profile.set_use_count(2);

syncer::SyncChangeList expected_change_list;