components/autofill/core/browser/phone_number.cc - Issue 2110563002: Use AutofillProfileComparator in place of ad-hoc merge logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/phone_number.cc

Issue 2110563002: Use AutofillProfileComparator in place of ad-hoc merge logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@merge

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/phone_number.h ('k') | components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/phone_number.cc

diff --git a/components/autofill/core/browser/phone_number.cc b/components/autofill/core/browser/phone_number.cc

index 59f5e71834b2b3ecd30c4b460331751b5013fd3e..7dde9375f36febeee645ac3d71eca4133c35ea40 100644

--- a/components/autofill/core/browser/phone_number.cc

+++ b/components/autofill/core/browser/phone_number.cc

@@ -52,6 +52,13 @@ PhoneNumber& PhoneNumber::operator=(const PhoneNumber& number) {

return *this;

}

+bool PhoneNumber::operator==(const PhoneNumber& other) const {

+ if (this == &other)

+ return true;

+ return number_ == other.number_ && profile_ == other.profile_;

void PhoneNumber::GetSupportedTypes(ServerFieldTypeSet* supported_types) const {

supported_types->insert(PHONE_HOME_WHOLE_NUMBER);

supported_types->insert(PHONE_HOME_NUMBER);