Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: components/autofill/core/browser/autofill_merge_unittest.cc

Issue 2110563002: Use AutofillProfileComparator in place of ad-hoc merge logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@merge
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/core/browser/address.cc ('k') | components/autofill/core/browser/autofill_profile.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_merge_unittest.cc
diff --git a/components/autofill/core/browser/autofill_merge_unittest.cc b/components/autofill/core/browser/autofill_merge_unittest.cc
index 3b944a18031374048ee1c838e766fad451f9e572..3baf43244ecf6421c1bfb7802da92a1eb8766586 100644
--- a/components/autofill/core/browser/autofill_merge_unittest.cc
+++ b/components/autofill/core/browser/autofill_merge_unittest.cc
@@ -38,9 +38,8 @@ namespace {
const base::FilePath::CharType kTestName[] = FILE_PATH_LITERAL("merge");
const base::FilePath::CharType kFileNamePattern[] = FILE_PATH_LITERAL("*.in");
-const char kFieldSeparator[] = ": ";
+const char kFieldSeparator[] = ":";
const char kProfileSeparator[] = "---";
-const size_t kFieldOffset = arraysize(kFieldSeparator) - 1;
const ServerFieldType kProfileFieldTypes[] = {NAME_FIRST,
NAME_MIDDLE,
@@ -96,9 +95,12 @@ std::string SerializeProfiles(const std::vector<AutofillProfile*>& profiles) {
base::string16 value = profiles[i]->GetRawInfo(type);
result += AutofillType(type).ToString();
result += kFieldSeparator;
- base::ReplaceFirstSubstringAfterOffset(
- &value, 0, base::ASCIIToUTF16("\\n"), base::ASCIIToUTF16("\n"));
- result += base::UTF16ToUTF8(value);
+ if (!value.empty()) {
+ base::ReplaceFirstSubstringAfterOffset(
+ &value, 0, base::ASCIIToUTF16("\\n"), base::ASCIIToUTF16("\n"));
+ result += " ";
+ result += base::UTF16ToUTF8(value);
+ }
result += "\n";
}
}
@@ -239,8 +241,11 @@ void AutofillMergeTest::MergeProfiles(const std::string& profiles,
<< "Wrong format for separator on line " << i;
base::string16 field_type =
base::UTF8ToUTF16(line.substr(0, separator_pos));
+ do {
+ ++separator_pos;
+ } while (separator_pos < line.size() && line[separator_pos] == ' ');
base::string16 value =
- base::UTF8ToUTF16(line.substr(separator_pos + kFieldOffset));
+ base::UTF8ToUTF16(line.substr(separator_pos));
base::ReplaceFirstSubstringAfterOffset(
&value, 0, base::ASCIIToUTF16("\\n"), base::ASCIIToUTF16("\n"));
« no previous file with comments | « components/autofill/core/browser/address.cc ('k') | components/autofill/core/browser/autofill_profile.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698