Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/editing/Editor.h

Issue 2110543008: Move UndoStack from Page to Editor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments and rewrite test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/editing/undo/undo-iframe-location-change-expected.txt ('k') | third_party/WebKit/Source/core/editing/Editor.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/UndoStack.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/Editor.h
diff --git a/third_party/WebKit/Source/core/editing/Editor.h b/third_party/WebKit/Source/core/editing/Editor.h
index e2bd766a26d295c6f3010f3a02cfe89e87d24b9d..7182a4e2e90f22621bc96d7cd65411f8a9e1e549 100644
--- a/third_party/WebKit/Source/core/editing/Editor.h
+++ b/third_party/WebKit/Source/core/editing/Editor.h
@@ -253,6 +253,7 @@ public:
private:
Member<LocalFrame> m_frame;
Member<CompositeEditCommand> m_lastEditCommand;
+ Member<UndoStack> m_undoStack;
yosin_UTC9 2016/07/04 07:27:41 nit: Let's use|const Member<UndoStack>|, since it
Xiaocheng 2016/07/04 08:03:37 Done.
int m_preventRevealSelection;
bool m_shouldStartNewKillRingSequence;
bool m_shouldStyleWithCSS;
@@ -273,8 +274,6 @@ private:
bool canDeleteRange(const EphemeralRange&) const;
bool shouldDeleteRange(const EphemeralRange&) const;
- UndoStack* undoStack() const;
-
bool tryDHTMLCopy();
bool tryDHTMLCut();
bool tryDHTMLPaste(PasteMode);
« no previous file with comments | « third_party/WebKit/LayoutTests/editing/undo/undo-iframe-location-change-expected.txt ('k') | third_party/WebKit/Source/core/editing/Editor.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/UndoStack.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698