third_party/WebKit/Source/core/loader/FrameLoader.cpp - Issue 2110543008: Move UndoStack from Page to Editor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2110543008: Move UndoStack from Page to Editor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix layout test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

index 2e480c0c4290bfb72f1189103f626fb446adbe82..74ae88074df1dffb232994aa6cb00a9805cd96b8 100644

--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

@@ -270,8 +270,9 @@ void FrameLoader::dispatchUnloadEvent()

if (m_frame->document() && !SVGImage::isInSVGImage(m_frame->document()))

m_frame->document()->dispatchUnloadEvents();

- if (Page* page = m_frame->page())

- page->undoStack().didUnloadFrame(*m_frame);

+ // TODO(xiaochengh): can the undo stack be used again after frame unloading?

yosin_UTC9 2016/07/01 09:21:21 TL;DR: No, we don't use undo stack after frame unl

Xiaocheng 2016/07/04 06:29:23 I agree. Removed.

+ // If not, we can simply remove |UndoStack::didUnloadFrame()|.

+ m_frame->editor().undoStack().didUnloadFrame();

}

void FrameLoader::didExplicitOpen()