Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: third_party/WebKit/LayoutTests/editing/undo/undo-iframe-location-change.html

Issue 2110543008: Move UndoStack from Page to Editor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix layout test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/editing/undo/undo-iframe-location-change.html
diff --git a/third_party/WebKit/LayoutTests/editing/undo/undo-iframe-location-change.html b/third_party/WebKit/LayoutTests/editing/undo/undo-iframe-location-change.html
index 6b7aa2c2a280a7ec6ddfa73c5aaf1b622fb18015..f2c9888eb69f13fbbb816fde0743128fa5c31491 100644
--- a/third_party/WebKit/LayoutTests/editing/undo/undo-iframe-location-change.html
+++ b/third_party/WebKit/LayoutTests/editing/undo/undo-iframe-location-change.html
@@ -12,7 +12,7 @@ function log(message) {
function part1() {
yosin_UTC9 2016/07/01 09:21:21 Optional: Could you convert this test to use w3c t
Xiaocheng 2016/07/04 06:29:23 Done.
frames['iframe'].document.body.focus();
- // Hack to perform the editing command. Should be able to
+ // Hack to perform the editing command. Should not be able to
yosin_UTC9 2016/07/01 09:21:21 How about just say "Call execCommand for subframe
Xiaocheng 2016/07/04 06:29:23 Done (kind of).
// call execCommand on the main document.
frames['iframe'].document.execCommand('InsertText', false, 'c');
@@ -23,8 +23,8 @@ function part1() {
return;
}
- if (!document.queryCommandEnabled('Undo')) {
- log("FAIL: Undo is not enabled after text insertion.");
+ if (document.queryCommandEnabled('Undo')) {
+ log("FAIL: Undo is enabled in main document after text insertion in subframe.");
if (window.testRunner)
testRunner.notifyDone();
return;
@@ -40,7 +40,7 @@ function part2() {
if (!document.queryCommandEnabled('Undo'))
log("Success");
else
- log("Failure, Undo was still enabled after the location changed (but at least we didn't crash!)");
+ log("Failure, Undo is enabled after the location changed (but at least we didn't crash!)");
if (window.testRunner)
testRunner.notifyDone();

Powered by Google App Engine
This is Rietveld 408576698