Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2110543008: Move UndoStack from Page to Editor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use |const Member| and add notes to UndoStack class Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/page/Page.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All R ights Reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All R ights Reserved.
3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12 * Library General Public License for more details. 12 * Library General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU Library General Public License 14 * You should have received a copy of the GNU Library General Public License
15 * along with this library; see the file COPYING.LIB. If not, write to 15 * along with this library; see the file COPYING.LIB. If not, write to
16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17 * Boston, MA 02110-1301, USA. 17 * Boston, MA 02110-1301, USA.
18 */ 18 */
19 19
20 #include "core/page/Page.h" 20 #include "core/page/Page.h"
21 21
22 #include "core/css/resolver/ViewportStyleResolver.h" 22 #include "core/css/resolver/ViewportStyleResolver.h"
23 #include "core/dom/ClientRectList.h" 23 #include "core/dom/ClientRectList.h"
24 #include "core/dom/StyleChangeReason.h" 24 #include "core/dom/StyleChangeReason.h"
25 #include "core/dom/VisitedLinkState.h" 25 #include "core/dom/VisitedLinkState.h"
26 #include "core/editing/DragCaretController.h" 26 #include "core/editing/DragCaretController.h"
27 #include "core/editing/commands/UndoStack.h"
28 #include "core/editing/markers/DocumentMarkerController.h" 27 #include "core/editing/markers/DocumentMarkerController.h"
29 #include "core/events/Event.h" 28 #include "core/events/Event.h"
30 #include "core/fetch/ResourceFetcher.h" 29 #include "core/fetch/ResourceFetcher.h"
31 #include "core/frame/DOMTimer.h" 30 #include "core/frame/DOMTimer.h"
32 #include "core/frame/FrameConsole.h" 31 #include "core/frame/FrameConsole.h"
33 #include "core/frame/FrameHost.h" 32 #include "core/frame/FrameHost.h"
34 #include "core/frame/FrameView.h" 33 #include "core/frame/FrameView.h"
35 #include "core/frame/RemoteFrame.h" 34 #include "core/frame/RemoteFrame.h"
36 #include "core/frame/RemoteFrameView.h" 35 #include "core/frame/RemoteFrameView.h"
37 #include "core/frame/Settings.h" 36 #include "core/frame/Settings.h"
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 Page::Page(PageClients& pageClients) 108 Page::Page(PageClients& pageClients)
110 : SettingsDelegate(Settings::create()) 109 : SettingsDelegate(Settings::create())
111 , m_animator(PageAnimator::create(*this)) 110 , m_animator(PageAnimator::create(*this))
112 , m_autoscrollController(AutoscrollController::create(*this)) 111 , m_autoscrollController(AutoscrollController::create(*this))
113 , m_chromeClient(pageClients.chromeClient) 112 , m_chromeClient(pageClients.chromeClient)
114 , m_dragCaretController(DragCaretController::create()) 113 , m_dragCaretController(DragCaretController::create())
115 , m_dragController(DragController::create(this)) 114 , m_dragController(DragController::create(this))
116 , m_focusController(FocusController::create(this)) 115 , m_focusController(FocusController::create(this))
117 , m_contextMenuController(ContextMenuController::create(this, pageClients.co ntextMenuClient)) 116 , m_contextMenuController(ContextMenuController::create(this, pageClients.co ntextMenuClient))
118 , m_pointerLockController(PointerLockController::create(this)) 117 , m_pointerLockController(PointerLockController::create(this))
119 , m_undoStack(UndoStack::create())
120 , m_mainFrame(nullptr) 118 , m_mainFrame(nullptr)
121 , m_editorClient(pageClients.editorClient) 119 , m_editorClient(pageClients.editorClient)
122 , m_spellCheckerClient(pageClients.spellCheckerClient) 120 , m_spellCheckerClient(pageClients.spellCheckerClient)
123 , m_openedByDOM(false) 121 , m_openedByDOM(false)
124 , m_tabKeyCyclesThroughElements(true) 122 , m_tabKeyCyclesThroughElements(true)
125 , m_defersLoading(false) 123 , m_defersLoading(false)
126 , m_deviceScaleFactor(1) 124 , m_deviceScaleFactor(1)
127 , m_visibilityState(PageVisibilityStateVisible) 125 , m_visibilityState(PageVisibilityStateVisible)
128 , m_isCursorVisible(true) 126 , m_isCursorVisible(true)
129 #if ENABLE(ASSERT) 127 #if ENABLE(ASSERT)
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
467 { 465 {
468 visitor->trace(m_animator); 466 visitor->trace(m_animator);
469 visitor->trace(m_autoscrollController); 467 visitor->trace(m_autoscrollController);
470 visitor->trace(m_chromeClient); 468 visitor->trace(m_chromeClient);
471 visitor->trace(m_dragCaretController); 469 visitor->trace(m_dragCaretController);
472 visitor->trace(m_dragController); 470 visitor->trace(m_dragController);
473 visitor->trace(m_focusController); 471 visitor->trace(m_focusController);
474 visitor->trace(m_contextMenuController); 472 visitor->trace(m_contextMenuController);
475 visitor->trace(m_pointerLockController); 473 visitor->trace(m_pointerLockController);
476 visitor->trace(m_scrollingCoordinator); 474 visitor->trace(m_scrollingCoordinator);
477 visitor->trace(m_undoStack);
478 visitor->trace(m_mainFrame); 475 visitor->trace(m_mainFrame);
479 visitor->trace(m_validationMessageClient); 476 visitor->trace(m_validationMessageClient);
480 visitor->trace(m_frameHost); 477 visitor->trace(m_frameHost);
481 Supplementable<Page>::trace(visitor); 478 Supplementable<Page>::trace(visitor);
482 PageLifecycleNotifier::trace(visitor); 479 PageLifecycleNotifier::trace(visitor);
483 } 480 }
484 481
485 void Page::layerTreeViewInitialized(WebLayerTreeView& layerTreeView) 482 void Page::layerTreeViewInitialized(WebLayerTreeView& layerTreeView)
486 { 483 {
487 if (scrollingCoordinator()) 484 if (scrollingCoordinator())
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 { 532 {
536 } 533 }
537 534
538 Page::PageClients::~PageClients() 535 Page::PageClients::~PageClients()
539 { 536 {
540 } 537 }
541 538
542 template class CORE_TEMPLATE_EXPORT Supplement<Page>; 539 template class CORE_TEMPLATE_EXPORT Supplement<Page>;
543 540
544 } // namespace blink 541 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/page/Page.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698