Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: third_party/WebKit/Source/core/editing/commands/UndoStack.cpp

Issue 2110543008: Move UndoStack from Page to Editor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use |const Member| and add notes to UndoStack class Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007 Apple, Inc. All rights reserved. 2 * Copyright (C) 2006, 2007 Apple, Inc. All rights reserved.
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 10 matching lines...) Expand all
21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
25 */ 25 */
26 26
27 #include "core/editing/commands/UndoStack.h" 27 #include "core/editing/commands/UndoStack.h"
28 28
29 #include "core/dom/ContainerNode.h" 29 #include "core/dom/ContainerNode.h"
30 #include "core/editing/commands/UndoStep.h" 30 #include "core/editing/commands/UndoStep.h"
31 #include "platform/EventDispatchForbiddenScope.h"
32 #include "wtf/TemporaryChange.h" 31 #include "wtf/TemporaryChange.h"
33 32
34 namespace blink { 33 namespace blink {
35 34
36 // Arbitrary depth limit for the undo stack, to keep it from using 35 // Arbitrary depth limit for the undo stack, to keep it from using
37 // unbounded memory. This is the maximum number of distinct undoable 36 // unbounded memory. This is the maximum number of distinct undoable
38 // actions -- unbroken stretches of typed characters are coalesced 37 // actions -- unbroken stretches of typed characters are coalesced
39 // into a single action. 38 // into a single action.
40 static const size_t maximumUndoStackDepth = 1000; 39 static const size_t maximumUndoStackDepth = 1000;
41 40
(...skipping 14 matching lines...) Expand all
56 if (!m_inRedo) 55 if (!m_inRedo)
57 m_redoStack.clear(); 56 m_redoStack.clear();
58 m_undoStack.append(step); 57 m_undoStack.append(step);
59 } 58 }
60 59
61 void UndoStack::registerRedoStep(UndoStep* step) 60 void UndoStack::registerRedoStep(UndoStep* step)
62 { 61 {
63 m_redoStack.append(step); 62 m_redoStack.append(step);
64 } 63 }
65 64
66 void UndoStack::didUnloadFrame(const LocalFrame& frame)
67 {
68 EventDispatchForbiddenScope assertNoEventDispatch;
69 filterOutUndoSteps(m_undoStack, frame);
70 filterOutUndoSteps(m_redoStack, frame);
71 }
72
73 void UndoStack::filterOutUndoSteps(UndoStepStack& stack, const LocalFrame& frame )
74 {
75 UndoStepStack newStack;
76 while (!stack.isEmpty()) {
77 UndoStep* step = stack.first().get();
78 if (!step->belongsTo(frame))
79 newStack.append(step);
80 stack.removeFirst();
81 }
82 stack.swap(newStack);
83 }
84
85 bool UndoStack::canUndo() const 65 bool UndoStack::canUndo() const
86 { 66 {
87 return !m_undoStack.isEmpty(); 67 return !m_undoStack.isEmpty();
88 } 68 }
89 69
90 bool UndoStack::canRedo() const 70 bool UndoStack::canRedo() const
91 { 71 {
92 return !m_redoStack.isEmpty(); 72 return !m_redoStack.isEmpty();
93 } 73 }
94 74
(...skipping 22 matching lines...) Expand all
117 } 97 }
118 } 98 }
119 99
120 DEFINE_TRACE(UndoStack) 100 DEFINE_TRACE(UndoStack)
121 { 101 {
122 visitor->trace(m_undoStack); 102 visitor->trace(m_undoStack);
123 visitor->trace(m_redoStack); 103 visitor->trace(m_redoStack);
124 } 104 }
125 105
126 } // namespace blink 106 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/UndoStack.h ('k') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698