chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java - Issue 2110543004: Move JNI bindings for url_formatter from chrome to //components/url_formatter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

Issue 2110543004: Move JNI bindings for url_formatter from chrome to //components/url_formatter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkEditActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

index 02885751589a2cf7b4c077e6e0722fef5387ce4e..e2ca665ffd3e3cd0fa5b0949b869578264bfefda 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

@@ -29,9 +29,9 @@ import org.chromium.chrome.browser.download.ui.DownloadHistoryItemWrapper.Offlin

import org.chromium.chrome.browser.download.ui.DownloadManagerUi.DownloadUiObserver;

import org.chromium.chrome.browser.offlinepages.downloads.OfflinePageDownloadBridge;

import org.chromium.chrome.browser.offlinepages.downloads.OfflinePageDownloadItem;

-import org.chromium.chrome.browser.util.UrlUtilities;

import org.chromium.chrome.browser.widget.DateDividedAdapter;

import org.chromium.chrome.browser.widget.selection.SelectionDelegate;

+import org.chromium.components.url_formatter.UrlFormatter;

import java.util.ArrayList;

import java.util.List;

@@ -163,7 +163,7 @@ public class DownloadHistoryAdapter extends DateDividedAdapter implements Downlo

Context context = holder.mFilesizeView.getContext();

holder.mFilenameView.setText(item.getDisplayFileName());

holder.mHostnameView.setText(

- UrlUtilities.formatUrlForSecurityDisplay(item.getUrl(), false));

+ UrlFormatter.formatUrlForSecurityDisplay(item.getUrl(), false));

holder.mFilesizeView.setText(

Formatter.formatFileSize(context, item.getFileSize()));

holder.mItemView.initialize(item);