chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java - Issue 2110543004: Move JNI bindings for url_formatter from chrome to //components/url_formatter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

Issue 2110543004: Move JNI bindings for url_formatter from chrome to //components/url_formatter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gyp: conditionally exclude Android sources Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/util/UrlUtilities.java » ('j') | components/url_formatter/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

index 46668ebaf6e819fc83018ce25db3526a7632de22..3493633f44636981bd1e46c2a051ec686f3d6799 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

@@ -20,8 +20,8 @@ import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tab.TabDelegateFactory;

import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;

import org.chromium.chrome.browser.util.IntentUtils;

-import org.chromium.chrome.browser.util.UrlUtilities;

import org.chromium.components.service_tab_launcher.ServiceTabLauncher;

+import org.chromium.components.url_formatter.UrlFormatter;

import org.chromium.content_public.browser.LoadUrlParams;

import org.chromium.content_public.browser.WebContents;

import org.chromium.content_public.common.Referrer;

@@ -106,7 +106,7 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {

int parentId = parent != null ? parent.getId() : Tab.INVALID_TAB_ID;

// Sanitize the url.

- loadUrlParams.setUrl(UrlUtilities.fixupUrl(loadUrlParams.getUrl()));

+ loadUrlParams.setUrl(UrlFormatter.fixupUrl(loadUrlParams.getUrl()));

loadUrlParams.setTransitionType(getTransitionType(type, intent));

// Check if the tab is being created asynchronously.