components/url_formatter/android/BUILD.gn - Issue 2110543004: Move JNI bindings for url_formatter from chrome to //components/url_formatter

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/url_formatter/android/BUILD.gn

Issue 2110543004: Move JNI bindings for url_formatter from chrome to //components/url_formatter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gyp: conditionally exclude Android sources Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/url_formatter/BUILD.gn ('K') | « components/url_formatter/DEPS ('k') | components/url_formatter/android/component_jni_registrar.h » ('j') | components/url_formatter/android/component_jni_registrar.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import("//build/config/android/rules.gni")

	6

	7 android_library("url_formatter_java") {

	8 deps = [

	9 "//base:base_java",

	10 ]

	11

	12 java_files =

	13 [ "java/src/org/chromium/components/url_formatter/UrlFormatter.java" ]
	Peter Kasting 2016/07/01 06:59:33 Nit: Should this be formatted like the others?: Nit: Should this be formatted like the others?: java_files = [ "java/src/org/chromium/components/url_formatter/UrlFormatter.java", ]
	14 }

	15

	16 generate_jni("jni_headers") {

	17 sources = [

	18 "java/src/org/chromium/components/url_formatter/UrlFormatter.java",

	19 ]

	20

	21 jni_package = "url_formatter"

	22 }

OLD	NEW