Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 2110543003: Reland of actor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (Closed)

Created:
4 years, 5 months ago by Robert Sesek
Modified:
4 years, 5 months ago
Reviewers:
scottmg, Khushal
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of actor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2104083002/ ) Reason for revert: Revert unwarranted. Original issue's description: > Revert of Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2108683002/ ) > > Reason for revert: > A significant number of bots are broken after this landed. This is a speculative revert. Please re-land in case this was not the error. > > Original issue's description: > > Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. > > > > When comparing large targets like //chrome, it is nearly impossible to deal with > > the mountainous 46,000 lines of output the executable script produces. With an > > interactive environment, it is much easier to compare differences and drill-down > > into specific issues. > > > > BUG=622889 > > R=scottmg@chromium.org > > > > Committed: https://chromium.googlesource.com/chromium/src/+/9f1375ea1bfb9f35e48b69f4c10c8ffa3233ca2a > > TBR=scottmg@chromium.org,rsesek@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=622889 > > Committed: https://crrev.com/74af4d66235496370bd173c6139314e8adfecb2e > Cr-Commit-Position: refs/heads/master@{#402514} TBR=scottmg@chromium.org,khushalsagar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622889 Committed: https://crrev.com/db530b158baf864d61e74ef6d74a8938038ac7b0 Cr-Commit-Position: refs/heads/master@{#402533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -205 lines) Patch
M tools/gn/bin/gyp_flag_compare.py View 6 chunks +336 lines, -205 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Robert Sesek
Created Reland of actor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python.
4 years, 5 months ago (2016-06-28 20:15:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110543003/1
4 years, 5 months ago (2016-06-28 20:17:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 20:30:47 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 20:34:18 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db530b158baf864d61e74ef6d74a8938038ac7b0
Cr-Commit-Position: refs/heads/master@{#402533}

Powered by Google App Engine
This is Rietveld 408576698