Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 21105003: Simplify sampling rate calculation (Closed)

Created:
7 years, 4 months ago by yurys
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Simplify sampling rate calculation Sampling rate is now calculated as total number of samples divided by profiling time in ms. Before the patch the sampling rate was updated once per 100ms which doesn't have any obvious advantage over the simpler method. Also we are going to get rid of the profile node self and total time calculation in the v8 CPU profiler and only expose profiling start/end time for CpuProfile and number of ticks on each ProfileNode and let clients do all the math should they need it. BUG=None R=bmeurer@chromium.org, loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15944

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -142 lines) Patch
M src/cpu-profiler.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/cpu-profiler-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/profile-generator.h View 6 chunks +5 lines, -49 lines 0 comments Download
M src/profile-generator.cc View 4 chunks +18 lines, -32 lines 2 comments Download
M test/cctest/test-cpu-profiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 5 chunks +3 lines, -54 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yurys
7 years, 4 months ago (2013-07-29 17:55:09 UTC) #1
loislo
lgtm https://codereview.chromium.org/21105003/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): https://codereview.chromium.org/21105003/diff/1/src/profile-generator.cc#newcode379 src/profile-generator.cc:379: start_time_ms_(OS::TimeCurrentMillis()), Can we do that on the first ...
7 years, 4 months ago (2013-07-29 18:01:27 UTC) #2
yurys
https://codereview.chromium.org/21105003/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): https://codereview.chromium.org/21105003/diff/1/src/profile-generator.cc#newcode379 src/profile-generator.cc:379: start_time_ms_(OS::TimeCurrentMillis()), On 2013/07/29 18:01:27, loislo wrote: > Can we ...
7 years, 4 months ago (2013-07-29 18:13:21 UTC) #3
yurys
7 years, 4 months ago (2013-07-29 18:58:54 UTC) #4
Benedikt Meurer
LGTM.
7 years, 4 months ago (2013-07-30 06:19:02 UTC) #5
yurys
7 years, 4 months ago (2013-07-30 07:01:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r15944 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698