Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2110493002: Tighten up masking of colorType & alphaType in SkImageInfo serialization (for fuzzer bug) (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
msarett, bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Tighten up masking of colorType & alphaType in SkImageInfo serialization (for fuzzer bug) In this case the int that contains the color and alpha types is getting munged. We don't really case that the surplus bits are 0 just that the values we care about are reasonable. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2110493002 Committed: https://skia.googlesource.com/skia/+/c31bb870f274455197749cceea48c45c4b905d6e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/core/SkImageInfo.cpp View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
robertphillips
4 years, 5 months ago (2016-06-28 17:39:39 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110493002/1
4 years, 5 months ago (2016-06-28 17:39:49 UTC) #6
reed1
4 years, 5 months ago (2016-06-28 17:42:25 UTC) #8
msarett
lgtm
4 years, 5 months ago (2016-06-28 17:47:36 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 18:00:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110493002/1
4 years, 5 months ago (2016-06-28 18:01:36 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 18:02:33 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c31bb870f274455197749cceea48c45c4b905d6e

Powered by Google App Engine
This is Rietveld 408576698