Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc

Issue 2110483002: Remove use of CanonicalCookie::Source() from browsing_data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Really really fix android? Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc b/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc
index 0220cd5cd2e0eff963a8371c6aa853729353134b..d8c9decf6f073f28a31d02a25ff7fa9392df90a3 100644
--- a/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc
+++ b/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc
@@ -22,8 +22,6 @@ class CookieExpectation {
CookieExpectation() {}
bool MatchesCookie(const net::CanonicalCookie& cookie) const {
- if (!source_.is_empty() && source_ != cookie.Source())
- return false;
if (!domain_.empty() && domain_ != cookie.Domain())
return false;
if (!path_.empty() && path_ != cookie.Path())
@@ -189,9 +187,10 @@ class BrowsingDataCookieHelperTest : public testing::Test {
ASSERT_EQ(3U, cookie_list.size());
}
- void DeleteCookie(BrowsingDataCookieHelper* helper, const GURL origin) {
+ void DeleteCookie(BrowsingDataCookieHelper* helper,
+ const std::string& domain) {
for (const auto& cookie : cookie_list_) {
- if (cookie.Source() == origin)
+ if (cookie.Domain() == domain)
helper->DeleteCookie(cookie);
}
}
@@ -265,7 +264,7 @@ TEST_F(BrowsingDataCookieHelperTest, CannedDeleteCookie) {
EXPECT_EQ(2u, helper->GetCookieCount());
- DeleteCookie(helper.get(), origin1);
+ DeleteCookie(helper.get(), origin1.host());
EXPECT_EQ(1u, helper->GetCookieCount());
helper->StartFetching(

Powered by Google App Engine
This is Rietveld 408576698