Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2110453002: add swarmbucketcheck (Closed)

Created:
4 years, 5 months ago by nodir
Modified:
4 years, 5 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

add swarmbucketcheck swarmbucketcheck is a tool that finds discrepancies between buildbot and swarming builds R=vadimsh@chromium.org BUG=622950 Committed: https://chromium.googlesource.com/infra/infra/+/df10537c1d3778b89e2ac72a7e91c3c818983b94

Patch Set 1 #

Patch Set 2 : add swarmbucketcheck #

Total comments: 2

Patch Set 3 : copyright #

Patch Set 4 : coverage #

Patch Set 5 : coverage #

Messages

Total messages: 18 (9 generated)
nodir
PTAL
4 years, 5 months ago (2016-06-28 16:46:18 UTC) #1
Vadim Sh.
lgtm https://codereview.chromium.org/2110453002/diff/20001/go/src/infra/tools/swarming-transition/cmd/swarmbucketcheck/main.go File go/src/infra/tools/swarming-transition/cmd/swarmbucketcheck/main.go (right): https://codereview.chromium.org/2110453002/diff/20001/go/src/infra/tools/swarming-transition/cmd/swarmbucketcheck/main.go#newcode1 go/src/infra/tools/swarming-transition/cmd/swarmbucketcheck/main.go:1: package main copyright
4 years, 5 months ago (2016-06-28 18:17:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110453002/40001
4 years, 5 months ago (2016-06-28 22:08:54 UTC) #5
nodir
https://codereview.chromium.org/2110453002/diff/20001/go/src/infra/tools/swarming-transition/cmd/swarmbucketcheck/main.go File go/src/infra/tools/swarming-transition/cmd/swarmbucketcheck/main.go (right): https://codereview.chromium.org/2110453002/diff/20001/go/src/infra/tools/swarming-transition/cmd/swarmbucketcheck/main.go#newcode1 go/src/infra/tools/swarming-transition/cmd/swarmbucketcheck/main.go:1: package main On 2016/06/28 18:17:14, Vadim Sh. wrote: > ...
4 years, 5 months ago (2016-06-28 22:08:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Infra Mac Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Mac%20Tester/builds/2648)
4 years, 5 months ago (2016-06-28 22:17:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110453002/60001
4 years, 5 months ago (2016-06-28 22:42:34 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Infra Mac Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Mac%20Tester/builds/2652)
4 years, 5 months ago (2016-06-28 22:50:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110453002/80001
4 years, 5 months ago (2016-06-28 22:53:53 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 23:14:20 UTC) #18
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/infra/infra/+/df10537c1d3778b89e2ac72a7e91c...

Powered by Google App Engine
This is Rietveld 408576698