Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2110443002: Add a flutter benchmark; refactor (Closed)

Created:
4 years, 5 months ago by Brian Wilkerson
Modified:
4 years, 5 months ago
Reviewers:
scheglov, pquitslund
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -131 lines) Patch
M pkg/analysis_server/benchmark/perf/benchmark_local.dart View 1 chunk +175 lines, -131 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
Added one new benchmark (local_initialAnalysis_3). Added some error checking. Moved benchmarks to top-level functions. Added ...
4 years, 5 months ago (2016-06-28 16:25:59 UTC) #2
pquitslund
lgtm
4 years, 5 months ago (2016-06-28 16:28:19 UTC) #3
scheglov
LGTM Sort maybe.
4 years, 5 months ago (2016-06-28 16:30:40 UTC) #4
Brian Wilkerson
4 years, 5 months ago (2016-06-28 17:27:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
221e92f1720cfe751720622200014fde2a825c82 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698