Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2110363003: Consolidate WebInputEvent Coalescing unit tests (Closed)

Created:
4 years, 5 months ago by tapted
Modified:
4 years, 5 months ago
Reviewers:
tdresser
CC:
chromium-reviews, darin-cc_chromium.org, jam, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consolidate WebInputEvent Coalescing unit tests They were previously split across EventWithLatencyInfo and WebInputEventTraits tests, but EventWithLatencyInfo was decoupled from WebInputEventTraits in r403402. BUG=625000 Committed: https://crrev.com/63119c20ac70ec63df097d0bf0901b4ad0d2ae2e Cr-Commit-Position: refs/heads/master@{#403627}

Patch Set 1 #

Patch Set 2 : nit diff #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -257 lines) Patch
M content/common/input/event_with_latency_info_unittest.cc View 1 3 chunks +243 lines, -34 lines 2 comments Download
M content/common/input/web_input_event_traits_unittest.cc View 2 chunks +1 line, -223 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tapted
Hi Tim, please take a look. Thanks! https://codereview.chromium.org/2110363003/diff/20001/content/common/input/event_with_latency_info_unittest.cc File content/common/input/event_with_latency_info_unittest.cc (right): https://codereview.chromium.org/2110363003/diff/20001/content/common/input/event_with_latency_info_unittest.cc#newcode164 content/common/input/event_with_latency_info_unittest.cc:164: Everything below ...
4 years, 5 months ago (2016-07-01 07:39:40 UTC) #3
tdresser
Thanks for the cleanup. LGTM https://codereview.chromium.org/2110363003/diff/20001/content/common/input/event_with_latency_info_unittest.cc File content/common/input/event_with_latency_info_unittest.cc (right): https://codereview.chromium.org/2110363003/diff/20001/content/common/input/event_with_latency_info_unittest.cc#newcode164 content/common/input/event_with_latency_info_unittest.cc:164: On 2016/07/01 07:39:40, tapted ...
4 years, 5 months ago (2016-07-01 12:52:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110363003/20001
4 years, 5 months ago (2016-07-04 01:28:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-04 02:05:25 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 02:06:35 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63119c20ac70ec63df097d0bf0901b4ad0d2ae2e
Cr-Commit-Position: refs/heads/master@{#403627}

Powered by Google App Engine
This is Rietveld 408576698