Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: chrome/browser/geolocation/geolocation_permission_context.cc

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/geolocation/geolocation_permission_context.cc
diff --git a/chrome/browser/geolocation/geolocation_permission_context.cc b/chrome/browser/geolocation/geolocation_permission_context.cc
index 10ca37e0f1d046bda4c38e61048a9273e7d7d7f1..a8db90b050dd8e2dcaf95e3b72b6a5d3abd50ce6 100644
--- a/chrome/browser/geolocation/geolocation_permission_context.cc
+++ b/chrome/browser/geolocation/geolocation_permission_context.cc
@@ -28,14 +28,15 @@ void GeolocationPermissionContext::DecidePermission(
const PermissionRequestID& id,
const GURL& requesting_origin,
const GURL& embedding_origin,
+ bool user_gesture,
const BrowserPermissionCallback& callback) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
bool permission_set;
bool new_permission;
if (extensions_context_.DecidePermission(
- web_contents, id, id.request_id(), requesting_origin, callback,
- &permission_set, &new_permission)) {
+ web_contents, id, id.request_id(), requesting_origin, user_gesture,
+ callback, &permission_set, &new_permission)) {
if (permission_set) {
ContentSetting content_setting =
new_permission ? CONTENT_SETTING_ALLOW : CONTENT_SETTING_BLOCK;
@@ -53,6 +54,7 @@ void GeolocationPermissionContext::DecidePermission(
id,
requesting_origin,
embedding_origin,
+ user_gesture,
callback);
}

Powered by Google App Engine
This is Rietveld 408576698