blimp/engine/app/blimp_permission_manager.h - Issue 2110343002: Reintroduce plumbing for user gesture into permission system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/app/blimp_permission_manager.h

Issue 2110343002: Reintroduce plumbing for user gesture into permission system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatting Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/aw_permission_manager.cc ('k') | blimp/engine/app/blimp_permission_manager.cc » ('j') | chrome/browser/permissions/permission_context_base_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/engine/app/blimp_permission_manager.h

diff --git a/blimp/engine/app/blimp_permission_manager.h b/blimp/engine/app/blimp_permission_manager.h

index 7b09262abd9c957c00659bc2fbd2e3bdf1f6c98b..8b016cd197428049c2a73d847d23dd4bea12f0df 100644

--- a/blimp/engine/app/blimp_permission_manager.h

+++ b/blimp/engine/app/blimp_permission_manager.h

@@ -24,12 +24,14 @@ class BlimpPermissionManager : public content::PermissionManager {

content::PermissionType permission,

content::RenderFrameHost* render_frame_host,

const GURL& requesting_origin,

+ bool user_gesture,

const base::Callback<void(blink::mojom::PermissionStatus)>& callback)

override;

int RequestPermissions(

const std::vector<content::PermissionType>& permission,

content::RenderFrameHost* render_frame_host,

const GURL& requesting_origin,

+ bool user_gesture,

const base::Callback<

void(const std::vector<blink::mojom::PermissionStatus>&)>& callback)

override;