chrome/browser/media/webrtc_log_uploader_unittest.cc - Issue 211033006: Move destruction of WebRtcLogUploader to post threads teardown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/webrtc_log_uploader_unittest.cc

Issue 211033006: Move destruction of WebRtcLogUploader to post threads teardown. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Minor fix to unit test + rebase. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media/webrtc_log_uploader_unittest.cc

diff --git a/chrome/browser/media/webrtc_log_uploader_unittest.cc b/chrome/browser/media/webrtc_log_uploader_unittest.cc

index 9cc00b4efde9af563c443c66a834ee76e2cf8c25..36b28e77a8d737ce615a4a8a143f9926623697ea 100644

--- a/chrome/browser/media/webrtc_log_uploader_unittest.cc

+++ b/chrome/browser/media/webrtc_log_uploader_unittest.cc

@@ -175,6 +175,8 @@ TEST_F(WebRtcLogUploaderTest, AddLocallyStoredLogInfoToUploadListFile) {

kTestLocalId);

ASSERT_TRUE(VerifyNumberOfLines(expected_line_limit));

ASSERT_TRUE(VerifyLastLineHasLocalIdOnly());

+ webrtc_log_uploader_->StartShutdown();

}

TEST_F(WebRtcLogUploaderTest, AddUploadedLogInfoToUploadListFile) {

@@ -199,4 +201,6 @@ TEST_F(WebRtcLogUploaderTest, AddUploadedLogInfoToUploadListFile) {

test_list_path_, "dummy id", kTestReportId);

ASSERT_TRUE(VerifyNumberOfLines(2));

ASSERT_TRUE(VerifyLastLineHasUploadTimeAndIdOnly());

+ webrtc_log_uploader_->StartShutdown();

}