Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Side by Side Diff: chrome/browser/media/webrtc_logging_handler_host.h

Issue 211033006: Move destruction of WebRtcLogUploader to post threads teardown. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Minor fix to unit test + rebase. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_MEDIA_WEBRTC_LOGGING_HANDLER_HOST_H_ 5 #ifndef CHROME_BROWSER_MEDIA_WEBRTC_LOGGING_HANDLER_HOST_H_
6 #define CHROME_BROWSER_MEDIA_WEBRTC_LOGGING_HANDLER_HOST_H_ 6 #define CHROME_BROWSER_MEDIA_WEBRTC_LOGGING_HANDLER_HOST_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/shared_memory.h" 9 #include "base/memory/shared_memory.h"
10 #include "content/public/browser/browser_message_filter.h" 10 #include "content/public/browser/browser_message_filter.h"
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 // Gets the log directory path for |profile_| and ensure it exists. Must be 122 // Gets the log directory path for |profile_| and ensure it exists. Must be
123 // called on the FILE thread. 123 // called on the FILE thread.
124 base::FilePath GetLogDirectoryAndEnsureExists(); 124 base::FilePath GetLogDirectoryAndEnsureExists();
125 125
126 void TriggerUploadLog(const base::FilePath& log_directory); 126 void TriggerUploadLog(const base::FilePath& log_directory);
127 127
128 void FireGenericDoneCallback(GenericDoneCallback* callback, 128 void FireGenericDoneCallback(GenericDoneCallback* callback,
129 bool success, 129 bool success,
130 const std::string& error_message); 130 const std::string& error_message);
131 131
132 scoped_refptr<net::URLRequestContextGetter> system_request_context_;
133
134 scoped_ptr<unsigned char[]> log_buffer_; 132 scoped_ptr<unsigned char[]> log_buffer_;
135 scoped_ptr<PartialCircularBuffer> circular_buffer_; 133 scoped_ptr<PartialCircularBuffer> circular_buffer_;
136 134
137 // The profile associated with our renderer process. 135 // The profile associated with our renderer process.
138 Profile* profile_; 136 Profile* profile_;
139 137
140 // These are only accessed on the IO thread, except when in STARTING state. In 138 // These are only accessed on the IO thread, except when in STARTING state. In
141 // this state we are protected since entering any function that alters the 139 // this state we are protected since entering any function that alters the
142 // state is not allowed. 140 // state is not allowed.
143 MetaDataMap meta_data_; 141 MetaDataMap meta_data_;
(...skipping 14 matching lines...) Expand all
158 156
159 // This is the handle to be passed to the render process. It's stored so that 157 // This is the handle to be passed to the render process. It's stored so that
160 // it doesn't have to be passed on when posting messages between threads. 158 // it doesn't have to be passed on when posting messages between threads.
161 // It's only accessed on the IO thread. 159 // It's only accessed on the IO thread.
162 base::SharedMemoryHandle foreign_memory_handle_; 160 base::SharedMemoryHandle foreign_memory_handle_;
163 161
164 DISALLOW_COPY_AND_ASSIGN(WebRtcLoggingHandlerHost); 162 DISALLOW_COPY_AND_ASSIGN(WebRtcLoggingHandlerHost);
165 }; 163 };
166 164
167 #endif // CHROME_BROWSER_MEDIA_WEBRTC_LOGGING_HANDLER_HOST_H_ 165 #endif // CHROME_BROWSER_MEDIA_WEBRTC_LOGGING_HANDLER_HOST_H_
OLDNEW
« no previous file with comments | « chrome/browser/media/webrtc_log_uploader_unittest.cc ('k') | chrome/browser/media/webrtc_logging_handler_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698