Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: tools/perf/benchmarks/battor.py

Issue 2110273002: Use correct overhead level for benchmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: blob_storage Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/perf/benchmarks/blob_storage.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 from telemetry.web_perf import timeline_based_measurement 6 from telemetry.web_perf import timeline_based_measurement
7 import page_sets 7 import page_sets
8 from telemetry import benchmark 8 from telemetry import benchmark
9 9
10 10
11 # TODO(rnephew): Remove BattOr naming from all benchmarks once the BattOr tests 11 # TODO(rnephew): Remove BattOr naming from all benchmarks once the BattOr tests
12 # are the primary means of benchmarking power. 12 # are the primary means of benchmarking power.
13 class _BattOrBenchmark(perf_benchmark.PerfBenchmark): 13 class _BattOrBenchmark(perf_benchmark.PerfBenchmark):
14 14
15 def CreateTimelineBasedMeasurementOptions(self): 15 def CreateTimelineBasedMeasurementOptions(self):
16 options = timeline_based_measurement.Options() 16 options = timeline_based_measurement.Options()
17 options.config.enable_battor_trace = True 17 options.config.enable_battor_trace = True
18 options.config.enable_chrome_trace = True 18 options.config.enable_chrome_trace = True
19 options.config.chrome_trace_config.SetMinimalOverheadFilter() 19 options.config.chrome_trace_config.SetDefaultOverheadFilter()
20 options.SetTimelineBasedMetric('powerMetric') 20 options.SetTimelineBasedMetric('powerMetric')
21 return options 21 return options
22 22
23 @classmethod 23 @classmethod
24 def ShouldDisable(cls, possible_browser): 24 def ShouldDisable(cls, possible_browser):
25 # Only run if BattOr is detected. 25 # Only run if BattOr is detected.
26 if not possible_browser.platform.HasBattOrConnected(): 26 if not possible_browser.platform.HasBattOrConnected():
27 return True 27 return True
28 28
29 # Galaxy S5s have problems with running system health metrics. 29 # Galaxy S5s have problems with running system health metrics.
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 97
98 98
99 @benchmark.Disabled('android') # crbug.com/618330 99 @benchmark.Disabled('android') # crbug.com/618330
100 class BattOrPowerCasesNoChromeTrace(_BattOrBenchmark): 100 class BattOrPowerCasesNoChromeTrace(_BattOrBenchmark):
101 page_set = page_sets.power_cases.PowerCasesPageSet 101 page_set = page_sets.power_cases.PowerCasesPageSet
102 102
103 def CreateTimelineBasedMeasurementOptions(self): 103 def CreateTimelineBasedMeasurementOptions(self):
104 options = timeline_based_measurement.Options() 104 options = timeline_based_measurement.Options()
105 options.config.enable_battor_trace = True 105 options.config.enable_battor_trace = True
106 options.config.enable_chrome_trace = False 106 options.config.enable_chrome_trace = False
107 options.config.chrome_trace_config.SetMinimalOverheadFilter() 107 options.config.chrome_trace_config.SetDefaultOverheadFilter()
108 options.SetTimelineBasedMetric('powerMetric') 108 options.SetTimelineBasedMetric('powerMetric')
109 return options 109 return options
110 110
111 @classmethod 111 @classmethod
112 def Name(cls): 112 def Name(cls):
113 return 'battor.power_cases_no_chrome_trace' 113 return 'battor.power_cases_no_chrome_trace'
OLDNEW
« no previous file with comments | « no previous file | tools/perf/benchmarks/blob_storage.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698