DevTools: Remove event Console.messageRepeatCountUpdated

Source/devtools/front_end/ConsoleView.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 85 matching lines @@
     this.messagesElement.addEventListener("contextmenu", this._handleContextMenuEvent.bind(this), false);
 
     WebInspector.settings.monitoringXHREnabled.addChangeListener(this._monitoringXHREnabledSettingChanged.bind(this));
 
     this._linkifier = new WebInspector.Linkifier();
 
     /** @type {!Map.<!WebInspector.ConsoleMessage, !WebInspector.ConsoleViewMessage>} */
     this._messageToViewMessage = new Map();
     /** @type {!Array.<!WebInspector.ConsoleMessage>} */
     this._consoleMessages = [];
+    this._previous_message = null;

[pfeldman, 2014/03/25 13:09:32]

You want this._previousMessage

[sergeyv, 2014/03/25 13:42:56]

Done.

 
     this.prompt = new WebInspector.TextPromptWithHistory(this._completionsForTextPrompt.bind(this));
     this.prompt.setSuggestBoxEnabled("generic-suggest");
     this.prompt.renderAsBlock();
     this.prompt.attach(this.promptElement);
     this.prompt.proxyElement.addEventListener("keydown", this._promptKeyDown.bind(this), false);
     this.prompt.setHistoryData(WebInspector.settings.consoleHistory.get());
 
     WebInspector.targetManager.targets().forEach(this._targetAdded, this);
     WebInspector.targetManager.addEventListener(WebInspector.TargetManager.Events.TargetAdded, this._onTargetAdded, this);
@@ skipping 20 matching lines @@
         this._targetAdded(/**@type {!WebInspector.Target} */(event.data));
     },
 
     /**
      * @param {!WebInspector.Target} target
      */
     _targetAdded: function(target)
     {
         target.consoleModel.addEventListener(WebInspector.ConsoleModel.Events.MessageAdded, this._onConsoleMessageAdded.bind(this, target), this);
         target.consoleModel.addEventListener(WebInspector.ConsoleModel.Events.ConsoleCleared, this._consoleCleared, this);
-        target.consoleModel.addEventListener(WebInspector.ConsoleModel.Events.RepeatCountUpdated, this._repeatCountUpdated, this);
         target.consoleModel.addEventListener(WebInspector.ConsoleModel.Events.CommandEvaluated, this._commandEvaluated, this);
         target.consoleModel.messages.forEach(this._consoleMessageAdded.bind(this, target));
 
         /**
          * @param {!WebInspector.ExecutionContextList} contextList
          * @this {WebInspector.ConsoleView}
          */
         function loadContextList(contextList)
         {
             this._addExecutionContextList(target, contextList);
@@ skipping 252 matching lines @@
         count = (typeof count === "undefined") ? (this._consoleMessages.length - this._visibleViewMessages.length) : count;
         this._filterStatusTextElement.textContent = WebInspector.UIString(count == 1 ? "%d message is hidden by filters." : "%d messages are hidden by filters.", count);
         this._filterStatusMessageElement.style.display = count ? "" : "none";
     },
 
     /**
      * @param {!WebInspector.ConsoleMessage} message
      */
     _consoleMessageAdded: function(target, message)
     {
-        this._consoleMessages.push(message);
-        var viewMessage = this._createViewMessage(target, message);
         if (this._urlToMessageCount[message.url])
             this._urlToMessageCount[message.url]++;
         else
             this._urlToMessageCount[message.url] = 1;
 
+        if (this._previous_message && !message.isGroupMessage() && message.isEqual(this._previous_message)) {
+            this._messageToViewMessage.get(this._previous_message).incrementRepeatCount();
+            return;
+        }
+
+        this._consoleMessages.push(message);
+        this._previous_message = message;
+        var viewMessage = this._createViewMessage(target, message);
+
         if (this._filter.shouldBeVisible(viewMessage))
             this._showConsoleMessage(viewMessage);
         else
             this._updateFilterStatus();
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _onConsoleMessageAdded: function(target, event)
@@ skipping 57 matching lines @@
     {
         this._scrolledToBottom = true;
         this._clearCurrentSearchResultHighlight();
         this._updateFilterStatus(0);
 
         for (var i = 0; i < this._visibleViewMessages.length; ++i)
             this._visibleViewMessages[i].willHide();
 
         this._visibleViewMessages = [];
         this._searchResults = [];
+        this._previous_message = null;
         this._messageToViewMessage.clear();
         this._consoleMessages = [];
 
         if (this._searchRegex)
             this._searchableView.updateSearchMatchesCount(0);
 
         this.currentGroup = this.topGroup;
         this.topGroup.messagesElement.removeChildren();
 
         this._linkifier.reset();
     },
 
-    /**
-     * @param {!WebInspector.Event} event
-     */
-    _repeatCountUpdated: function(event)
-    {
-        var message = /** @type {!WebInspector.ConsoleMessage} */ (event.data);
-        this._messageToViewMessage.get(message).updateRepeatCount();
-    },
-
     _handleContextMenuEvent: function(event)
     {
         if (event.target.enclosingNodeOrSelfWithNodeName("a"))
             return;
 
         var contextMenu = new WebInspector.ContextMenu(event);
 
         function monitoringXHRItemAction()
         {
             WebInspector.settings.monitoringXHREnabled.set(!WebInspector.settings.monitoringXHREnabled.get());
@@ skipping 534 matching lines @@
  * @param {?WebInspector.ConsoleCommand} originatingCommand
  * @param {!WebInspector.Linkifier} linkifier
  * @param {string=} url
  * @param {number=} lineNumber
  * @param {number=} columnNumber
  */
 WebInspector.ConsoleCommandResult = function(result, wasThrown, originatingCommand, linkifier, url, lineNumber, columnNumber)
 {
     this.originatingCommand = originatingCommand;
     var level = wasThrown ? WebInspector.ConsoleMessage.MessageLevel.Error : WebInspector.ConsoleMessage.MessageLevel.Log;
-    var message = new WebInspector.ConsoleMessage(WebInspector.ConsoleMessage.MessageSource.JS, level, "", WebInspector.ConsoleMessage.MessageType.Result, url, lineNumber, columnNumber, undefined, undefined, [result]);
+
+    var message = new WebInspector.ConsoleMessage(WebInspector.ConsoleMessage.MessageSource.JS, level, "", WebInspector.ConsoleMessage.MessageType.Result, url, lineNumber, columnNumber, undefined, [result]);
     WebInspector.ConsoleViewMessage.call(this, result.target(), message, linkifier);
 }
 
 WebInspector.ConsoleCommandResult.prototype = {
     /**
      * @override
      * @param {!WebInspector.RemoteObject} array
      * @return {boolean}
      */
     useArrayPreviewInFormatter: function(array)
@@ skipping 85 matching lines @@
         var node = this.messagesElement.firstChild;
         while (node) {
             if (node.classList.contains("console-message") && node.message)
                 node.message.wasShown();
             if (node.classList.contains("console-group") && node.group)
                 node.group.wasShown();
             node = node.nextSibling;
         }
     }
 }