Do all parsing for try/catch destructuring inside the appropriate scopes

Do all parsing for try/catch destructuring inside the appropriate scopes

Previously, any expressions inside destructuring patterns in a catch
would be parsed in the surrounding scope, instead of in the catch's
scope. This change fixes that by entering not only the catch scope,
but also the block scope inside it.

R=neis@chromium.org
BUG=v8:5106, v8:5112
Committed: https://crrev.com/7166503f6e90949f4d3ac6902d737966c2c1c08c
Cr-Commit-Position: refs/heads/master@{#37415}

[adamk, 2016-06-29 22:04:22]

Description was changed from

==========
Do all parsing for try/catch destructuring inside the appropriate scopes

Previously, any expressions inside destructuring patterns in a catch
would be parsed in the surrounding scope, instead of in the catch's
scope. This change fixes that by entering not only the catch scope,
but also the block scope inside it.

R=neis@chromium.org
BUG=v8:5106
==========

to

==========
Do all parsing for try/catch destructuring inside the appropriate scopes

Previously, any expressions inside destructuring patterns in a catch
would be parsed in the surrounding scope, instead of in the catch's
scope. This change fixes that by entering not only the catch scope,
but also the block scope inside it.

As an added bonus, add one more block scope for the catch block's
body itself (as required by the spec), thus passing another test262
test and taking care of a TODO.

R=neis@chromium.org
BUG=v8:5106
==========

[adamk, 2016-06-29 22:04:52]

Description was changed from

==========
Do all parsing for try/catch destructuring inside the appropriate scopes

Previously, any expressions inside destructuring patterns in a catch
would be parsed in the surrounding scope, instead of in the catch's
scope. This change fixes that by entering not only the catch scope,
but also the block scope inside it.

As an added bonus, add one more block scope for the catch block's
body itself (as required by the spec), thus passing another test262
test and taking care of a TODO.

R=neis@chromium.org
BUG=v8:5106
==========

to

==========
Do all parsing for try/catch destructuring inside the appropriate scopes

Previously, any expressions inside destructuring patterns in a catch
would be parsed in the surrounding scope, instead of in the catch's
scope. This change fixes that by entering not only the catch scope,
but also the block scope inside it.

As an added bonus, add one more block scope for the catch block's
body itself (as required by the spec), thus passing another test262
test and taking care of a TODO.

R=neis@chromium.org
BUG=v8:5106, v8:5112
==========

[adamk, 2016-06-29 23:02:03]

Description was changed from

==========
Do all parsing for try/catch destructuring inside the appropriate scopes

Previously, any expressions inside destructuring patterns in a catch
would be parsed in the surrounding scope, instead of in the catch's
scope. This change fixes that by entering not only the catch scope,
but also the block scope inside it.

As an added bonus, add one more block scope for the catch block's
body itself (as required by the spec), thus passing another test262
test and taking care of a TODO.

R=neis@chromium.org
BUG=v8:5106, v8:5112
==========

to

==========
Do all parsing for try/catch destructuring inside the appropriate scopes

Previously, any expressions inside destructuring patterns in a catch
would be parsed in the surrounding scope, instead of in the catch's
scope. This change fixes that by entering not only the catch scope,
but also the block scope inside it.

R=neis@chromium.org
BUG=v8:5106, v8:5112
==========

[neis, 2016-06-30 06:47:06]

Thanks! lgtm

https://codereview.chromium.org/2110193002/diff/100001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2110193002/diff/100001/src/parsing/parser.cc#...
src/parsing/parser.cc:3058: // add an additional block scope for the catch body.
Is this related to the remaining test262 failure?

[neis, 2016-06-30 06:47:19]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2016-06-30 06:47:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 06:49:27]

Description was changed from

==========
Do all parsing for try/catch destructuring inside the appropriate scopes

Previously, any expressions inside destructuring patterns in a catch
would be parsed in the surrounding scope, instead of in the catch's
scope. This change fixes that by entering not only the catch scope,
but also the block scope inside it.

R=neis@chromium.org
BUG=v8:5106, v8:5112
==========

to

==========
Do all parsing for try/catch destructuring inside the appropriate scopes

Previously, any expressions inside destructuring patterns in a catch
would be parsed in the surrounding scope, instead of in the catch's
scope. This change fixes that by entering not only the catch scope,
but also the block scope inside it.

R=neis@chromium.org
BUG=v8:5106, v8:5112
==========

[commit-bot: I haz the power, 2016-06-30 06:49:27]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-30 06:52:22]

Description was changed from

==========
Do all parsing for try/catch destructuring inside the appropriate scopes

Previously, any expressions inside destructuring patterns in a catch
would be parsed in the surrounding scope, instead of in the catch's
scope. This change fixes that by entering not only the catch scope,
but also the block scope inside it.

R=neis@chromium.org
BUG=v8:5106, v8:5112
==========

to

==========
Do all parsing for try/catch destructuring inside the appropriate scopes

Previously, any expressions inside destructuring patterns in a catch
would be parsed in the surrounding scope, instead of in the catch's
scope. This change fixes that by entering not only the catch scope,
but also the block scope inside it.

R=neis@chromium.org
BUG=v8:5106, v8:5112

Committed: https://crrev.com/7166503f6e90949f4d3ac6902d737966c2c1c08c
Cr-Commit-Position: refs/heads/master@{#37415}
==========

[commit-bot: I haz the power, 2016-06-30 06:52:23]

Patchset 6 (id:??) landed as
https://crrev.com/7166503f6e90949f4d3ac6902d737966c2c1c08c
Cr-Commit-Position: refs/heads/master@{#37415}

[adamk, 2016-06-30 16:02:11]

https://codereview.chromium.org/2110193002/diff/100001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2110193002/diff/100001/src/parsing/parser.cc#...
src/parsing/parser.cc:3058: // add an additional block scope for the catch body.
On 2016/06/30 06:47:05, neis wrote:
> Is this related to the remaining test262 failure?

Yes, Kevin will fix this in his patch which fixes more conformance issues with
declarations in catch blocks.