Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2110183006: Introduce reauthenticateUserWithID:email:callback: (Closed)

Created:
4 years, 5 months ago by bzanotti
Modified:
4 years, 5 months ago
Reviewers:
msarda
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce reauthenticateUserWithID:email:callback: This new ChromeIdentityInteractionManager reauthenticate method is more flexible and allow the implementation to do some internal cleanup based on a unique identifier (the email can change). BUG=623928 Committed: https://crrev.com/9e3f106cd0403c1f5bc970bf35ea8f5c390f5e8b Cr-Commit-Position: refs/heads/master@{#403206}

Patch Set 1 #

Patch Set 2 : Better parameters name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.mm View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bzanotti
Please take a look.
4 years, 5 months ago (2016-06-30 13:11:05 UTC) #2
msarda
lgtm
4 years, 5 months ago (2016-06-30 15:56:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110183006/20001
4 years, 5 months ago (2016-06-30 16:40:46 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 17:20:43 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 17:20:59 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 17:22:17 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9e3f106cd0403c1f5bc970bf35ea8f5c390f5e8b
Cr-Commit-Position: refs/heads/master@{#403206}

Powered by Google App Engine
This is Rietveld 408576698